Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude_submit_bug #868

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: exclude_submit_bug #868

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33ac749
fix: exclude_submit_bug
EdoStorm96 Jan 16, 2025
0e650f5
fix: correct comparison operator
EdoStorm96 Jan 16, 2025
85579f3
style: black
EdoStorm96 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proposals/utils/stepper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def get_form_errors(self, exclude_submit=False):
# When using this method on the submit page, we
# use the form's own validation, otherwise it gets
# validated twice
if exclude_submit and item.form_class == ProposalSubmitForm:
if exclude_submit and getattr(item, "form_class", None) == ProposalSubmitForm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for equal identity of class types should be x is some_class not x == some_class. The latter is for eqaulity of value and is not well-defined for Forms.

We missed both these issues on the first pass, rip

continue
troublesome_pages.append(
{
Expand Down
Loading