-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenario card arrows added #149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3205575528
💛 - Coveralls |
NXXR
requested changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things that need to be addressed before merging:
- run formatting (
npm run format
) to make sure the code is properly formatted and passes the DevOps pipeline - fix the lince height of the compartments (the changes result in scenario card compartment entries with more space between rows which lead to a mismatch between the header rows and the compartment rows:
- address the changes suggested/mentioned by Martin in the last Sprint meeting (changing the "positive" direction/color of the arrows & adding a neutral option, changeing how incremental values are handled)
As discussed, to change condition of grey arrow. It should show when the change is not significant or less than 1% |
|
Closed
NXXR
requested changes
Sep 30, 2022
This was
linked to
issues
Oct 5, 2022
1 task
1 task
NXXR
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #147
There are problems of showing the arrows with the Recovered compartment.