Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scenario card arrows added #149

Merged
merged 9 commits into from
Oct 26, 2022
Merged

Conversation

Pawandeep-Kaur-Betz
Copy link
Collaborator

issue #147

There are problems of showing the arrows with the Recovered compartment.

@github-actions
Copy link

github-actions bot commented Jul 27, 2022

Unit Test Results

  1 files  ±0  12 suites  ±0   31s ⏱️ +4s
30 tests ±0  30 ✔️ ±0  0 💤 ±0  0 ±0 
31 runs  ±0  31 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 791e32c. ± Comparison against base commit d45a012.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Jul 27, 2022

Pull Request Test Coverage Report for Build 3205575528

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 20.145%

Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/components/ScenarioCard.tsx 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
frontend/src/components/Sidebar/DistrictMap.tsx 2 0%
Totals Coverage Status
Change from base Build 3204973303: 0.5%
Covered Lines: 231
Relevant Lines: 905

💛 - Coveralls

Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things that need to be addressed before merging:

  • run formatting (npm run format) to make sure the code is properly formatted and passes the DevOps pipeline
  • fix the lince height of the compartments (the changes result in scenario card compartment entries with more space between rows which lead to a mismatch between the header rows and the compartment rows:
    grafik
  • address the changes suggested/mentioned by Martin in the last Sprint meeting (changing the "positive" direction/color of the arrows & adding a neutral option, changeing how incremental values are handled)

@Pawandeep-Kaur-Betz
Copy link
Collaborator Author

As discussed, to change condition of grey arrow. It should show when the change is not significant or less than 1%

@Pawandeep-Kaur-Betz
Copy link
Collaborator Author

  • Stagnation rule applied, grey arrow will show up if the change is more than 3%.
  • Arrows also showing up on the basis of compartment value for those cases where RKI values are 0.

@JonasGilg JonasGilg requested a review from NXXR September 16, 2022 12:05
@NXXR NXXR mentioned this pull request Sep 30, 2022
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
@NXXR NXXR linked an issue Oct 5, 2022 that may be closed by this pull request
1 task
@NXXR NXXR removed a link to an issue Oct 5, 2022
1 task
@NXXR NXXR assigned Pawandeep-Kaur-Betz and unassigned NXXR Oct 25, 2022
@Pawandeep-Kaur-Betz Pawandeep-Kaur-Betz merged commit c5c7345 into develop Oct 26, 2022
@NXXR NXXR deleted the feature/scenarioCardArrows branch October 28, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of Scenario Cards
3 participants