Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade line chart to amCharts 5 #277

Merged
merged 29 commits into from
Jul 24, 2023
Merged

Conversation

NXXR
Copy link
Collaborator

@NXXR NXXR commented Jul 4, 2023

Description

This PR updates the line chart to use amCharts 5.

Related Issues

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Unit Test Results

  1 files  ±0  14 suites  ±0   33s ⏱️ +9s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 
33 runs  ±0  33 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 694ab8f. ± Comparison against base commit c7b98ae.

♻️ This comment has been updated with latest results.

frontend/src/components/SimulationChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/SimulationChart.tsx Outdated Show resolved Hide resolved
@NXXR NXXR requested a review from JonasGilg July 6, 2023 07:08
@JonasGilg
Copy link
Collaborator

Can you make the date selection a single click again?

@NXXR
Copy link
Collaborator Author

NXXR commented Jul 6, 2023

Can you make the date selection a single click again?

sorry,
forgot yesterday.
is fixed now.

Copy link
Collaborator

@JonasGilg JonasGilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels much better now. Sadly I discovered another issue. If you toggle a scenario or group filters the time selector goes missing :(

@NXXR
Copy link
Collaborator Author

NXXR commented Jul 6, 2023

Feels much better now. Sadly I discovered another issue. If you toggle a scenario or group filters the time selector goes missing :(

looking into it.
It seems to only happen when you activate/deactivate the first scenario or group filters, but not with the second scenario.
Can you confirm that?

@JonasGilg
Copy link
Collaborator

It seems to only happen when you activate/deactivate the first scenario or group filters, but not with the second scenario.
Can you confirm that?

Also happens with other scenarios/filters and when reloading the page.

@NXXR
Copy link
Collaborator Author

NXXR commented Jul 13, 2023

guide dissapperaing (#252 ) should be fixed now

@NXXR NXXR requested a review from JonasGilg July 13, 2023 14:09
frontend/src/components/SimulationChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/SimulationChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/SimulationChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/SimulationChart.tsx Outdated Show resolved Hide resolved
@NXXR NXXR requested a review from JonasGilg July 24, 2023 13:56
@NXXR NXXR merged commit 51024b2 into develop Jul 24, 2023
@NXXR NXXR deleted the feature/amcharts5-simulation-chart branch July 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants