Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade line chart to amCharts 5 #277

Merged
merged 29 commits into from
Jul 24, 2023
Merged

Upgrade line chart to amCharts 5 #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0acd4c1
amcharts5 upgrade
NXXR Jun 23, 2023
66aeac3
add export menu
NXXR Jun 29, 2023
16d2260
Merge remote-tracking branch 'origin/develop' into feature/amcharts5-…
NXXR Jun 29, 2023
43b606f
Merge remote-tracking branch 'origin/develop' into feature/amcharts5-…
NXXR Jun 29, 2023
9f89d0a
fix guard style
NXXR Jun 29, 2023
55c5e00
remove am4 code, ran formatter, moved percentile coloring, add backen…
NXXR Jun 30, 2023
05af8b5
format comments
NXXR Jun 30, 2023
1c40f83
fix group filter offset and resolve todo
NXXR Jun 30, 2023
70fc849
add vscode workspace settings
NXXR Jun 30, 2023
bd8fcff
reduce bundle size
NXXR Jun 30, 2023
bee306b
:arrow_down_small: remove obsolete amcharts4
NXXR Jun 30, 2023
3581953
resolve date format issues
NXXR Jul 4, 2023
0744a06
resolve date format issues
NXXR Jul 4, 2023
58436aa
reduce am5export import
NXXR Jul 4, 2023
a494007
resolve TODOs
NXXR Jul 4, 2023
6702c4e
reduce percentile opacity, fix effect triggers to redraw guide
NXXR Jul 4, 2023
a608c1d
change for loop to filter for finding series
NXXR Jul 4, 2023
c1a4b15
change for loop to filter for finding series
NXXR Jul 4, 2023
a7035b2
add error message if group filter data not available
NXXR Jul 4, 2023
1d46295
remove amcharts4 dependency
NXXR Jul 4, 2023
02d2bc8
apply format & lint
NXXR Jul 4, 2023
8096e1f
Apply suggestions from code review
NXXR Jul 6, 2023
d5eef7b
:memo: add changelog entries
NXXR Jul 6, 2023
68160db
change date select from dblclick to click
NXXR Jul 6, 2023
0869bb0
add effect conditions to date guide effect
NXXR Jul 11, 2023
b184d81
format and add todo
NXXR Jul 13, 2023
386f66b
reduce chart init effect so it only runs once
NXXR Jul 13, 2023
6455632
Merge branch 'develop' into feature/amcharts5-simulation-chart
NXXR Jul 14, 2023
694ab8f
Apply suggestions from code review
NXXR Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
*.tar

# ignore user/workspace settings etc. of VSCode
.vscode
1 change: 1 addition & 0 deletions frontend/docs/changelog/changelog-de.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Es wurden einige Verbesserungen gemacht, die das Laden der Seite beschleunigen.
- Wenn neue Funktionen zur Verfügung gestellt werden, wird der Browser-Cache nicht mehr verhindern, dass Benutzer:innen diese sehen.
- Das DLR-Logo wurde durch das LOKI-Logo ersetzt und verkleinert.
- Das Modul für das Liniendiagramm wurde von AmCharts 4 auf 5 gewechselt für eine bessere Leistung.

### Fehlerbehebungen

Expand Down
1 change: 1 addition & 0 deletions frontend/docs/changelog/changelog-en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Some improvements to page load speed have been made.
- If a new feature gets rolled out, the browser cache will no longer prevent the users from seeing it.
- The DLR logo was replaced by the LOKI logo and the size was reduced.
- The line chart module is upgraded from AmCharts 4 to 5 for better performance.

### Bug fixes

Expand Down
1,017 changes: 321 additions & 696 deletions frontend/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@
"**/*": "prettier --write --ignore-unknown"
},
"dependencies": {
"@amcharts/amcharts4": "^4.10.17",
"@amcharts/amcharts5": "^5.1.8",
"@amcharts/amcharts5": "^5.3.8",
"@emotion/react": "^11.10.5",
"@emotion/styled": "^11.10.5",
"@mui/icons-material": "^5.10.9",
Expand Down
4 changes: 4 additions & 0 deletions frontend/public/locales/de/global.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
dateFormat: 'dd. MMM yyyy',
dayFormat: 'dd. MMM',
topBar: {
'icon-alt': 'ESID Anwendungslogo',
language: 'Sprache',
Expand Down Expand Up @@ -51,6 +52,9 @@
},
chart: {
caseData: 'Falldaten',
date: 'Datum',
percentileUp: '0,75-Quantil',
percentileDown: '0,25-Quantil',
},
heatlegend: {
edit: 'Farblegende bearbeiten',
Expand Down
4 changes: 4 additions & 0 deletions frontend/public/locales/en/global.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
dateFormat: 'MMM dd. yyyy',
dayFormat: 'MMM dd.',
topBar: {
'icon-alt': 'ESID application logo',
language: 'Language',
Expand Down Expand Up @@ -60,6 +61,9 @@
},
chart: {
caseData: 'Case Data',
date: 'Date',
percentileUp: '75th percentile',
percentileDown: '25th percentile',
},
heatlegend: {
edit: 'Edit heatmap colors',
Expand Down
Loading