Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[나리] WEEK 03 Solutions #386

Merged
merged 5 commits into from
Aug 30, 2024
Merged

[나리] WEEK 03 Solutions #386

merged 5 commits into from
Aug 30, 2024

Conversation

naringst
Copy link
Contributor

@naringst naringst commented Aug 26, 2024

@naringst naringst self-assigned this Aug 26, 2024
@naringst naringst added the js label Aug 26, 2024
@BEMELON BEMELON self-requested a review August 26, 2024 13:36
@obzva obzva self-requested a review August 26, 2024 13:59
* **/

var twoSum = function (nums, target) {
let map = new Map();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프론트엔드 엔지니어로 일 할 땐 Map이 있다는 것만 알고 한 번도 써본 적이 없었는데 나리님께서 풀이에 사용하셨길래 좀 찾아보았습니다

(key, value) 쌍을 담는 컨테이너 역할로 사용하기엔 Map이 더 편한 구석이 많다는 것 알아갑니다 :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 현업에서는 아직 써본 적은 없는데, 이번 기회로 필요하다면 써봐야겠다는 생각을 했습니다! 감사합니다~

@BEMELON BEMELON removed their request for review August 26, 2024 22:50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 나리님, 나누기 연산자를 사용하면 안 된다고 문제에 적혀 있습니다.

You must write an algorithm that runs in O(n) time and without using the division operation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 해당 문장을 못봣네요 ㅜㅜ 😨

@naringst naringst marked this pull request as ready for review August 30, 2024 12:58
@naringst naringst requested a review from a team as a code owner August 30, 2024 12:58
@obzva
Copy link
Contributor

obzva commented Aug 30, 2024

draft에서 PR로 전환하셨길래 이번 차수는 4문제까지만 푸시는 걸로 이해했습니다 :)
고생하셨습니다~

@naringst
Copy link
Contributor Author

draft에서 PR로 전환하셨길래 이번 차수는 4문제까지만 푸시는 걸로 이해했습니다 :) 고생하셨습니다~

너무 리뷰 시작점이 늦어지는 것 같아 리뷰는 4번까지만 받아도 괜찮으니 미리 review로 돌려놨습니다! 감사합니다~

@naringst naringst merged commit 34f0816 into DaleStudy:main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants