Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] new orchestrion go weblog #3555

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Nov 26, 2024

Motivation

Provide simple testing features for https://github.com/DataDog/orchestrion

Changes

  • Copy-paste of the net-http variant into a net-http-orchestrion variant
  • Removal of all dd-trace-go SDK usage in this new variant
  • Creating a new install_orchestrion.sh script in the go weblog
  • Adding utility features for orchestrion for feature parity with the tracer
  • Changed 1 testsuite that had behaviour hardcoded for variant names
  • Disable all the same tests that could not pass because of net-http lack of path params

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch from fadae61 to 700c3dc Compare January 9, 2025 16:13
@eliottness eliottness changed the title [golang] switch go weblog to orchestrion [golang] new orchestrion go weblog Jan 9, 2025
@eliottness eliottness added the go Pull requests that update Go code label Jan 9, 2025
@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch 3 times, most recently from 63d4f87 to 37dfad8 Compare January 10, 2025 15:11
Signed-off-by: Eliott Bouhana <[email protected]>

copy net-http into net-http-orchestrion

Signed-off-by: Eliott Bouhana <[email protected]>

revert net-http

Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch from 37dfad8 to 6828384 Compare January 13, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant