Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] new orchestrion go weblog #3555

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/execute/binaries.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ Create a file `golang-load-from-go-get` under the `binaries` directory that spec
* `gopkg.in/DataDog/[email protected]` Test the 1.67.0 release
* `gopkg.in/DataDog/dd-trace-go.v1@<commit_hash>` Test un-merged changes

To change Orchestrion version, create a file `orchestrion-load-from-go-get` under the `binaries` directory that specifies the target build. The content of this file will be installed by the weblog or parametric app via `go get` when the test image is built.
* Content example:
* `github.com/DataDog/orchestrion@main` Test the main branch
* `github.com/DataDog/[email protected]` Test the 1.1.0 release
* `github.com/DataDog/orchestrion@<commit_hash>` Test un-merged changes

## Java library

Follow these steps to run Parametric tests with a custom Java Tracer version:
Expand Down
26 changes: 25 additions & 1 deletion manifests/golang.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ tests/:
Test_API_Security_Sampling_Rate:
'*': v1.60.0
net-http: irrelevant (net-http doesn't handle path params)
net-http-orchestrion: irrelevant (net-http doesn't handle path params)
Test_API_Security_Sampling_With_Delay: missing_feature
test_schemas.py:
Test_Scanners: missing_feature
Expand All @@ -32,6 +33,7 @@ tests/:
Test_Schema_Request_Path_Parameters:
'*': v1.60.0
net-http: irrelevant (net-http cannot list path params)
net-http-orchestrion: irrelevant (net-http cannot list path params)
Test_Schema_Request_Query_Parameters: v1.60.0
Test_Schema_Response_Body: missing_feature
Test_Schema_Response_Body_env_var: missing_feature
Expand Down Expand Up @@ -217,6 +219,7 @@ tests/:
'*': v1.36.0
gin: v1.37.0
net-http: irrelevant (net-http doesn't handle path params)
net-http-orchestrion: irrelevant (net-http doesn't handle path params)
Test_ResponseStatus:
'*': v1.36.0
gin: v1.37.0
Expand Down Expand Up @@ -337,21 +340,27 @@ tests/:
Test_Blocking_request_cookies:
'*': v1.51.0
net-http: irrelevant
net-http-orchestrion: irrelevant
Test_Blocking_request_headers:
'*': v1.51.0
net-http: irrelevant
net-http-orchestrion: irrelevant
Test_Blocking_request_method:
'*': v1.51.0
net-http: irrelevant
net-http-orchestrion: irrelevant
Test_Blocking_request_path_params:
'*': v1.51.0
net-http: irrelevant
net-http-orchestrion: irrelevant
Test_Blocking_request_query:
'*': v1.51.0
net-http: irrelevant
net-http-orchestrion: irrelevant
Test_Blocking_request_uri:
'*': v1.51.0
net-http: irrelevant
net-http-orchestrion: irrelevant
Test_Blocking_response_headers: missing_feature
Test_Blocking_response_status: missing_feature
Test_Blocking_user_id: v1.51.0
Expand Down Expand Up @@ -457,21 +466,26 @@ tests/:
Test_Kinesis_PROPAGATION_VIA_MESSAGE_ATTRIBUTES:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
test_rabbitmq.py:
Test_RabbitMQ_Trace_Context_Propagation:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
test_sns_to_sqs.py:
Test_SNS_Propagation:
"*": irrelevant
net-http: missing_feature
net-http-orchestrion: missing_feature (Endpoint not implemented)
test_sqs.py:
Test_SQS_PROPAGATION_VIA_AWS_XRAY_HEADERS:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_SQS_PROPAGATION_VIA_MESSAGE_ATTRIBUTES:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
test_db_integrations_sql.py:
Test_MsSql: missing_feature
Test_MySql: missing_feature
Expand All @@ -492,27 +506,35 @@ tests/:
Test_DsmKinesis:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_DsmRabbitmq:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_DsmRabbitmq_FanoutExchange:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_DsmRabbitmq_TopicExchange:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_DsmSNS:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_DsmSQS:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_Dsm_Manual_Checkpoint_Inter_Process:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
Test_Dsm_Manual_Checkpoint_Intra_Process:
"*": irrelevant
net-http: missing_feature (Endpoint not implemented)
net-http-orchestrion: missing_feature (Endpoint not implemented)
test_inferred_proxy.py:
Test_AWS_API_Gateway_Inferred_Span_Creation: missing_feature
test_otel_drop_in.py:
Expand Down Expand Up @@ -592,7 +614,9 @@ tests/:
Test_Config_ClientTagQueryString_Configured: missing_feature (supports DD_TRACE_HTTP_URL_QUERY_STRING_DISABLED)
Test_Config_ClientTagQueryString_Empty: bug (APMAPI-966) # DD_TRACE_HTTP_CLIENT_TAG_QUERY_STRING is disabled by default
Test_Config_HttpClientErrorStatuses_Default: v1.69.0
Test_Config_HttpClientErrorStatuses_FeatureFlagCustom: v1.69.0
Test_Config_HttpClientErrorStatuses_FeatureFlagCustom:
'*': v1.69.0
net-http-orchestrion: v1.72.0-dev
Test_Config_HttpServerErrorStatuses_Default: v1.67.0
Test_Config_HttpServerErrorStatuses_FeatureFlagCustom:
"*": v1.69.0
Expand Down
1 change: 1 addition & 0 deletions tests/test_semantic_conventions.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"graphql-go": "graphql-go/graphql",
"jersey-grizzly2": {"jakarta-rs.request": "jakarta-rs-controller", "grizzly.request": ["grizzly", "jakarta-rs"]},
"net-http": "net/http",
"net-http-orchestrion": "net/http",
"sinatra": {"rack.request": "rack"},
"spring-boot": {
"servlet.request": "tomcat-server",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_standard_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def test_route(self):
if context.library == "nodejs":
tags["http.route"] = "/sample_rate_route/:i"
if context.library == "golang":
if context.weblog_variant == "net-http":
if "net-http" in context.weblog_variant:
# net/http doesn't support parametrized routes but a path catches anything down the tree.
tags["http.route"] = "/sample_rate_route/"
if context.weblog_variant in ("gin", "echo", "uds-echo"):
Expand Down
Loading
Loading