Added more Syndicate Uniforms to the Emagged Uniform Printer #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
|
Howdy! We are taking this under for direction review, expect a response in 24 hours. Looks good at first glance! |
deltanedas
requested changes
Dec 28, 2024
Signed-off-by: deltanedas <[email protected]>
deltanedas
approved these changes
Dec 28, 2024
|
Howdy, as much as I appreciate this, I don't appreciate using the art without asking me (Or crediting me, which is fine (but still kinda annoying) since the original PR is linked). I'm totally fine with it, and I'm sure you didn't have any ill intentions. Unless this PR isn't adding the clothes or something and I'm stupid. Also, don't forget to add the copyright stuff when adding the clothes, and I'm the one who made em! @justanorange on Discord if you have more questions about it, i'm not really that deep into SS14 atm. |
|
nevermind im a stupid moron and this isn't adding the clothes at all and i am dumb |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
First PR Time.
Ive Added the Delta-V syndicate uniforms to the Emagged uniform printer.
Specifically: the Cybersun Lawyer Jumpsuit, the Interdyne Jumpsuit, Chemsuit and Gas mask, and the Cybersun Surgeon Jumpsuit, Surgical Cap and Windbreaker.
Ive also already added the recipes for PR#2285's Additional items, but have commented them out until it is merged, to be uncommented after testing that they actually work
Why / Balance
Why? The Upstream Uniform printer lets you print every syndicate uniform they have, Parity with DeltaVs new ones makes sense.
Now, This does allow people to print the Windbreaker, which has a 5% dmg resistance to pierce, slash, blunt and 20% Heat
and the Chemsuit which has 60% Caustic Armor with a very Civilian machine, I personally think that there are far more powerful things one can do with an EMAG and that these vanity items pale in comparrison.
In addition, this PR also allows the uniform printer to create the Interdyne gasmask, which is not only a bit unfitting for a uniform printer, but also currently the only method i know of to make gas masks.
I did not wish to split up the uniforms into different machines or leave them incomplete, so i think this is fine considering the Price of Admission (an EMAG, plus stealing or Making a Uniprinter)
Technical details
YML Changes only, modified two Upstream files, but i believe ive commented them appropriately, recipes for items that dont exist yet commented out.
Media
How to Test
Requirements
Breaking changes
N/A
Changelog
🆑