Editing "marine bed", "shoreline", "sea surface layer" - addressing #1122 #1125
Conversation
Good point - we had the same thing come up over here. Adding those stand alone annotations as annotations on the definitions would be much appreciated! |
I stand corrected! @cmungall just explained here that these class annotations are mappings, rather than definition sources and should thus remain as standalone annotations on the class level. |
|
Hi @pbuttigieg I have edited the definition of shoreline accordingly (see above). Thanks for your semantics help. Do you have any other suggestions or comments? |
src/envo/envo-edit.owl
Outdated
| @@ -11198,12 +11198,21 @@ SubClassOf(<http://purl.obolibrary.org/obo/ENVO_00000481> ObjectSomeValuesFrom(< | |||
|
|
|||
| # Class: <http://purl.obolibrary.org/obo/ENVO_00000482> (sea floor) | |||
|
|
|||
| AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "MA:ma"^^xsd:string) <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_00000482> "The ground surface that lies beneath a sea."^^xsd:string) | |||
| AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> <https://en.wikipedia.org/wiki/Seabed>) Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "MA:ma"^^xsd:string) <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_00000482> "A marine bed which is covered by marine sediments."^^xsd:string) | |||
There was a problem hiding this comment.
A marine bed which is covered by marine sediments.
Not sure about this. Isn't the bed boundary defined by the sediments? I suppose the confusion comes from the use of the ambiguous word "ground" in submerged bed.
And there is a difference between oceans and seas which supports the use of both sea floor and ocean floor.
src/envo/envo-edit.owl
Outdated
| @@ -33524,9 +33545,14 @@ SubClassOf(<http://purl.obolibrary.org/obo/ENVO_01001570> ObjectSomeValuesFrom(< | |||
| # Class: <http://purl.obolibrary.org/obo/ENVO_01001581> (sea surface layer) | |||
|
|
|||
| AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_01001581> "A surface layer of a water body which is part of an ocean or sea.") | |||
There was a problem hiding this comment.
A surface layer of a water body which is part of an ocean or sea.
I'd say: "A surface layer which is part of an ocean or sea."
This is a semantic ambiguity fix, as SSL is used to refer to the surfaces of oceans too. That should be added as a comment.
In fact, even with seafloor and ocean floor, we should add related synonyms for the other term, with annotation properties on those synonyms (comments) saying they're there as these terms are used so loosely.
|
Hi @pbuttigieg, Thanks for clarify the difference between sea and ocean! I have edited the definition accordingly. Please let me know if you have further suggestions. |
Dear editors,
I have edited terms "marine bed", "shoreline", and "sea surface floor" as mentioned in issue #1122. I also added German, Italian, Spanish and Mandarin interpretations to them, and include them in envoPlastics subset.
As mentioned in the issue, we are considering to obsolete sea floor and ocean floor as they are synonyms for
marine bed. But we are not sure what goes into making that decision and also how to do it.Another point I notice while editing
shorelineis itsdatabase_cross_referenceis a stand alone annotation. As they are not all website line but text (e.g.FTT:503, FTT240), I wasn't sure is it appropriate to change them under definition.Thank you!