Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tclune/#81 compute coords locally #258

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Feature/tclune/#81 compute coords locally #258

merged 3 commits into from
Nov 9, 2023

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Oct 26, 2023

Updated fv3.j to include the new control flag for using the new and improved coordinate calculations in dycore.

mathomp4 and others added 2 commits September 28, 2023 10:17
@mathomp4
Merge pull request #255 from GEOS-ESM/develop
32b7768 
GitFlow: Merge develop into main for release
@tclune
Added new option to run script.
70a90d3 
User can set `compute_coords_locally` to `.true.` to reduce
memory usage and improve accuracy of lat lon coords.

Default is `.false.` to preserve backward compatibility.
@tclune tclune added enhancement New feature or request 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Needs Lead Approval Change requires science lead approval Skip Changelog labels Oct 26, 2023
@tclune tclune requested a review from a team as a code owner October 26, 2023 15:28
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

4 similar comments
@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

@github-actions
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

@mathomp4 mathomp4 requested a review from wmputman October 26, 2023 17:55
@mathomp4
Copy link
Member

I can confirm this along with GEOS-ESM/GFDL_atmos_cubed_sphere#83 is zero-diff.

cc: @wmputman

@mathomp4 mathomp4 mentioned this pull request Oct 26, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Needs Lead Approval, Skip Changelog

@mathomp4
Copy link
Member

mathomp4 commented Nov 1, 2023

I had to do a merge here. so I'll do one more test to make sure all is zero-diff.

@mathomp4 mathomp4 mentioned this pull request Nov 6, 2023
Merged
@mathomp4 mathomp4 added the Contingent - DNA These changes are contingent on other PRs label Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: enhancement, 0 diff, Contingent - DNA, Needs Lead Approval, Skip Changelog

@mathomp4 mathomp4 mentioned this pull request Nov 6, 2023
Merged
@mathomp4 mathomp4 removed Contingent - DNA These changes are contingent on other PRs Needs Lead Approval Change requires science lead approval labels Nov 9, 2023
@mathomp4
Copy link
Member

mathomp4 commented Nov 9, 2023

Now that fvdycore geos/v2.7.0 is out, we can release this.

@mathomp4 mathomp4 merged commit 596ec50 into develop Nov 9, 2023
11 of 13 checks passed
@mathomp4 mathomp4 deleted the feature/tclune/#81-compute-coords-locally branch October 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@wmputman wmputman Awaiting requested review from wmputman

Assignees

@wmputman wmputman

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tclune @mathomp4 @wmputman