Feature/tclune/#81 compute coords locally #83
Conversation
So far only tested in ESMF CubedSphere constructor. Committing now to transfer to a test environment.
Same routines for computing new coordinates now in both packages.
tclune
added
Non 0-diff
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog |
3 similar comments
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Non 0-diff, Needs Lead Approval, Skip Changelog |
tclune
added
0 diff
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog |
1 similar comment
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog |
|
I confirm that this along with GEOS-ESM/FVdycoreCubed_GridComp#258 is zero-diff (when not activated, of course) |
(Off by one error in an unusual sense.)
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Needs Lead Approval, Skip Changelog |
This PR introduces new algorithms for computing lat lon corners of cubed sphere. These new routines use far less memory, as no global domain arrays are involved. They are also arguably more accurate, and run faster not that the latter are significant concerns.
These have not been validated in GEOS, and the default behavior is to use the older coordinates for backward compatibility. This can be toggled by seting
compute_coords_locally = .true.in thefv_core_nmlnamelist.