-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Download Manager Toast Information #1095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, left a couple comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@flavioislima I confirmed I am seeing the download times on the library game page and download page match the download modal.
|
That is because it did not was updated with main, I did it now if you want to test again. |
This refactors part of the Download Manager Toast component so it can use the same progress that we use in other places like the game page and the download page.
This should fix the differences in downloaded bytes and ETA, especially for the extracting method that its not precise right now.
Also added a new Hook that we can use as a source of truth to get both the
gameInfo
and theinstallInfo
from any game.Current issues
Fixed on this branch
(Note that the download size is 0 due to a bug fixed on #1066)
Use the following Checklist if you have changed something on the Backend or Frontend: