Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Download Manager Toast Information #1095

Merged
merged 7 commits into from
Oct 11, 2024
Merged

[FIX] Download Manager Toast Information #1095

merged 7 commits into from
Oct 11, 2024

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Oct 1, 2024

This refactors part of the Download Manager Toast component so it can use the same progress that we use in other places like the game page and the download page.
This should fix the differences in downloaded bytes and ETA, especially for the extracting method that its not precise right now.

Also added a new Hook that we can use as a source of truth to get both the gameInfo and the installInfo from any game.

Current issues

Captura de imagem_20241001_122405

Captura de imagem_20241001_122451

Fixed on this branch

Captura de imagem_20241001_121056
(Note that the download size is 0 due to a bug fixed on #1066)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this Oct 1, 2024
@flavioislima flavioislima added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 1, 2024
Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, left a couple comments

src/frontend/hooks/useGameInfo.ts Outdated Show resolved Hide resolved
src/frontend/hooks/hasProgress.ts Show resolved Hide resolved
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 8, 2024
@nyghtstalker
Copy link

@flavioislima I confirmed I am seeing the download times on the library game page and download page match the download modal.

  • I confirmed on main and this is not occurring. My concern is this PR will bring this into main. The size is displaying as 0 on the Downloading and Downloaded tabs.

image
image
image
image

@flavioislima
Copy link
Contributor Author

@flavioislima I confirmed I am seeing the download times on the library game page and download page match the download modal.

  • I confirmed on main and this is not occurring. My concern is this PR will bring this into main. The size is displaying as 0 on the Downloading and Downloaded tabs.

That is because it did not was updated with main, I did it now if you want to test again.
I started this pr before the other was merged.

@flavioislima flavioislima merged commit 3a644dd into main Oct 11, 2024
10 checks passed
@flavioislima flavioislima deleted the fix/dm_toaster branch October 11, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants