-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kwxm/bls flat uncompression #5663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwxm
added
Do not merge
EXPERIMENT
Experiments that we probably don't want to merge
No Changelog Required
Add this to skip the Changelog Check
labels
Dec 3, 2023
kwxm
added
Builtins
and removed
EXPERIMENT
Experiments that we probably don't want to merge
No Changelog Required
Add this to skip the Changelog Check
labels
Dec 6, 2023
I think that this should be ready to go once #5664 is merged. We should rebase this branch on that and then run
to update the costs of the BLS12-381 test cases in |
We should probably also add a test to make sure that serialising script containing a G1 or G2 constant fails. I'm nor sure how do that right now though. |
This needs to go in the specification too. See PLT-8902. |
v0d1ch
pushed a commit
to v0d1ch/plutus
that referenced
this pull request
Dec 6, 2024
* WIP * WIP * WIP * WIP * WIP * Remove old generator and zero constants * Remove old generator and zero constants * Add local copy of G1 generator for experimentation * Add local copy of G1 generator for experimentation * Expand comment * Expand comment * Remove accidental newlines * Remove accidental newlines * Update bls cost test results * Update comments * Update comments * Remove workarounds for premature application * Restore previous versions of some tests * Restore previous versions of some tests * Remove comment * Represent compressed group points as byte arrays * Better definitions of compressed group points * Add changelog entries * update test output --------- Co-authored-by: Michael Peyton Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is just an experiment and I want so see if it gets through CI.This changes the
Flat
instances for the BLS12-381G1
andG2
Element
types to disallow uncompression during script flat-deseriailisation. Users should now use the appropriateuncompress
methods explicitly to uncompress any group constants that are required in scripts.For convenience (for example, in tests), literal constants of the form
(con bls12_381_G1_element 0x...)
are still allowed in textual PLC programs, but any attempt to serialise such a program in theflat
format will fail.