Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compressed files #678

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Improve compressed files #678

merged 4 commits into from
Nov 19, 2024

Conversation

lievenhey
Copy link
Contributor

No description provided.

@lievenhey lievenhey force-pushed the improve-compressed-files branch from bfadfbf to cda87b4 Compare September 17, 2024 16:59
@lievenhey
Copy link
Contributor Author

This is a fix for the currently broken compressed files feature. The current implementation doesn't work, because I passed the compressed file to perfparser. This patch series fixes that and adds support for archives files so that hotspot can now open zip and tar.gz files.

@lievenhey lievenhey force-pushed the improve-compressed-files branch 2 times, most recently from 034b188 to 8d006ea Compare September 17, 2024 17:13
@GitMensch
Copy link
Contributor

GitMensch commented Sep 18, 2024 •
edited
Loading

Does this overlap with #663?

milianw
milianw requested changes Sep 26, 2024
View reviewed changes
src/parsers/perf/perfparser.cpp Outdated Show resolved Hide resolved
src/parsers/perf/perfparser.cpp Show resolved Hide resolved
tests/integrationtests/tst_perfparser.cpp Show resolved Hide resolved
milianw
milianw reviewed Sep 26, 2024
View reviewed changes
tests/integrationtests/tst_perfparser.cpp Outdated Show resolved Hide resolved
tests/integrationtests/tst_perfparser.cpp Outdated Show resolved Hide resolved
@lievenhey lievenhey mentioned this pull request Sep 26, 2024
Merged
@GitMensch GitMensch mentioned this pull request Oct 7, 2024
Open
@lievenhey lievenhey force-pushed the improve-compressed-files branch 2 times, most recently from b6820b0 to 3797ada Compare October 11, 2024 08:59
@lievenhey lievenhey force-pushed the improve-compressed-files branch from 3797ada to 76bbf2a Compare October 11, 2024 09:38
@lievenhey lievenhey requested a review from milianw October 11, 2024 09:58
@lievenhey
Copy link
Contributor Author

Ok I found a way to make it work with one function.
That patch also refactors a lot of code. Mainly the use of #include <../utils.h> in the model classes. This is done by moving that code to the models.

@lievenhey lievenhey merged commit ce87b50 into master Nov 19, 2024
25 checks passed
@lievenhey lievenhey deleted the improve-compressed-files branch November 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milianw milianw milianw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lievenhey @GitMensch @milianw