Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 계좌번호 이름 확인 구현 #149

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Conversation

wlwpfh
Copy link
Collaborator

@wlwpfh wlwpfh commented Dec 10, 2023

✨ 관련 이슈

closed #147

✨ 변경 사항 및 이유

  • 계좌성명 연동을 하였습니다.
  • 필요한 이름, 은행코드, 계좌번호를 받습니다.
  • 받은 후 이름과 같은지 확인하여 에러를 보냅니다.
  • 같은 경우 200, 다른 경우 400를 주었습니다.
스크린샷 2023-12-10 오후 9 47 02

✨ PR Point

  • 감사합니다 ^ ^)

@wlwpfh wlwpfh requested a review from yujindonut December 10, 2023 12:57
@wlwpfh wlwpfh self-assigned this Dec 10, 2023
Copy link
Member

@yujindonut yujindonut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지영언니 넘 고생했어
테스트 코드까지 미쳐따 .. 🤍


public void verifyUserAccount(String name, String BankCode, String AccountNumber) throws PopbillException {
try {
val accountInfo = accountCheckService.CheckAccountInfo(corpNum, BankCode, AccountNumber);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 메소드만 코드컨벤션과 다른 것 같습니다!
checkAccountInfo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 해당 API에서 제공하는 함수여서 컨벤션이 다릅니다!

@wlwpfh wlwpfh merged commit c077264 into develop Dec 11, 2023
1 check passed
@wlwpfh wlwpfh deleted the jiyoung_#147-account branch December 12, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 게좌번호 인증 API 연동
2 participants