-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 계좌번호 이름 확인 구현 #149
Merged
Merged
[FEAT] 계좌번호 이름 확인 구현 #149
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e4e8e32
[ADD] 계좌인증 라이브러리 설정
wlwpfh 16b5737
[ADD] 통신 DTO 추가
wlwpfh 19c36c9
[FEAT] 해당 에러 핸들러 추가
wlwpfh c8919c9
[ADD] 계좌 인증 성공 메시지 설정
wlwpfh cb814da
[FEAT] 계좌 인증 연동 설정
wlwpfh 41b454b
[DEL] 사용하지 않는 DTO 삭제
wlwpfh b4ad20a
[TEST] 유효하지 않은 기관코드의 경우 예와 발생
wlwpfh 1f3eaed
[ADD] 이름과 계좌 성명이 일치하지 않는 경우 예외 문구 추가
wlwpfh 5b0d889
[FEAT] 계좌번호 이름과 주어진 이름이 같은지 확인 추가
wlwpfh 9ec1ac4
[TEST] 필요한 인자 추가
wlwpfh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/test/java/com/sopterm/makeawish/service/UserServiceTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package com.sopterm.makeawish.service; | ||
|
||
import com.popbill.api.AccountCheckInfo; | ||
import com.popbill.api.AccountCheckService; | ||
import com.popbill.api.PopbillException; | ||
import org.checkerframework.checker.units.qual.A; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.TestInstance; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.boot.test.context.SpringBootTest; | ||
import org.springframework.transaction.annotation.Transactional; | ||
|
||
import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
||
|
||
@SpringBootTest | ||
@Transactional | ||
@TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
class UserServiceTest { | ||
@Autowired | ||
UserService userService; | ||
|
||
@Autowired | ||
AccountCheckService accountCheckService; | ||
|
||
@Test | ||
@DisplayName("유효하지 않은 기관코드인 경우 예외 발생") | ||
void 계좌_연동_실패(){ | ||
// given | ||
String BankCode = "0000"; | ||
String AccountNumber = "1234567890"; | ||
|
||
// when - then | ||
assertThatThrownBy(() -> userService.verifyUserAccount("홍길동",BankCode, AccountNumber)) | ||
.isInstanceOf(PopbillException.class); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 메소드만 코드컨벤션과 다른 것 같습니다!
checkAccountInfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 해당 API에서 제공하는 함수여서 컨벤션이 다릅니다!