Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --json for ip command output #251

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 5, 2024

It is better to use the JSON output format rather than regex and columnar output parsing since it is more reliable and repeatable

Depends on:

TODO:

  • Update spec mocks to use JSON output

@miq-bot miq-bot added the wip label Aug 5, 2024
@agrare agrare force-pushed the network_interface_ip_output_json branch from eac6752 to e9a0a8b Compare August 5, 2024 18:10
@agrare agrare force-pushed the network_interface_ip_output_json branch from e9a0a8b to 442804c Compare August 5, 2024 20:07
@agrare agrare mentioned this pull request Aug 6, 2024
1 task
@agrare agrare force-pushed the network_interface_ip_output_json branch from 442804c to 5c268b3 Compare August 6, 2024 17:14
@agrare agrare force-pushed the network_interface_ip_output_json branch from 5c268b3 to 3b3b128 Compare August 13, 2024 17:34
@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2024

Checked commit agrare@3b3b128 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare changed the title [WIP] Use --json for ip command output Use --json for ip command output Aug 13, 2024
@agrare agrare requested review from Fryguy and bdunne August 13, 2024 17:36
@agrare agrare added refactoring and removed wip labels Aug 13, 2024
@bdunne bdunne merged commit 016276e into ManageIQ:master Aug 13, 2024
5 checks passed
@bdunne bdunne self-assigned this Aug 13, 2024
@agrare agrare deleted the network_interface_ip_output_json branch August 13, 2024 19:17
bdunne added a commit that referenced this pull request Aug 13, 2024
Breaking Changes:
- Use --json for ip command output #251

Added:
- Add network interface loopback #254
- Add LinuxAdmin::NetworkInterface.list #249

Changed:
- Parse config file on NetworkInterface#reload #253

Test:
- Use ruby 3.1 and rails 7 for code coverage #250
- Fix rubocop warnings in NetworkInterface Spec #252
- Update paambaati/codeclimate-action action to v8 #248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants