-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
fix(12945): privacy mode and account selection bottom sheet (#12989)
## **Description** Issue: Privacy mode was not hiding account balances within the account selector bottom sheet at all Solution: Have the account selector bottom sheet component subscribe to the `privacyMode` prop which hides the balance of all accounts, introduce the `disablePrivacyMode` route params so that the account selector bottom sheet can opt out of privacy mode completely for certain flows. Cases where this is needed is in the send flow and swap flow. We do not hide the balance when a user needs to switch between accounts when sending/swapping ## **Related issues** Fixes: [#12945](#12945) ## **Manual testing steps** 1. Turn on privacy mode by clicking the eye icon within the portfolio balance at the top 2. Click on the account selector in the top to confirm balances for other accounts are hidden 3. Goto send and swap flow to confirm balances are NOT hidden even when privacy mode is ON ## **Screenshots/Recordings** ### Send Flow | Before | After | |:---:|:---:| |![before_swap_flow](https://github.com/user-attachments/assets/1a2f5430-8d40-4079-8d8b-187bde859022)|![after_swap_flow](https://github.com/user-attachments/assets/abe20b7d-1ba0-49f0-9848-41085f40bd87)| ### Swap Flow | Before | After | |:---:|:---:| |![before_send_flow](https://github.com/user-attachments/assets/7a43ea0e-a060-454c-9bed-d317e2c768a1)|![after_send_flow](https://github.com/user-attachments/assets/f7e4ed14-0c4e-4a3a-b8ae-812ce92efb4e)| ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent
b047169
commit 34f0a55
Showing
7 changed files
with
22 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters