Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(12945): privacy mode and account selection bottom sheet #12989

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Jan 15, 2025

Description

Issue: Privacy mode was not hiding account balances within the account selector bottom sheet at all

Solution: Have the account selector bottom sheet component subscribe to the privacyMode prop which hides the balance of all accounts, introduce the disablePrivacyMode route params so that the account selector bottom sheet can opt out of privacy mode completely for certain flows. Cases where this is needed is in the send flow and swap flow. We do not hide the balance when a user needs to switch between accounts when sending/swapping

Related issues

Fixes: #12945

Manual testing steps

  1. Turn on privacy mode by clicking the eye icon within the portfolio balance at the top
  2. Click on the account selector in the top to confirm balances for other accounts are hidden
  3. Goto send and swap flow to confirm balances are NOT hidden even when privacy mode is ON

Screenshots/Recordings

Send Flow

Before After
before_swap_flow after_swap_flow

Swap Flow

Before After
before_send_flow after_send_flow

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners January 15, 2025 01:50
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team team-ramp issues related to Ramp features labels Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2abd70e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aae00973-5ef1-4ee0-8bb3-7e46a545d07a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramp changes LGTM

Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation changes LGTM

@vinnyhoward vinnyhoward enabled auto-merge January 15, 2025 18:41
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward disabled auto-merge January 15, 2025 19:23
@vinnyhoward vinnyhoward enabled auto-merge January 15, 2025 19:24
@vinnyhoward vinnyhoward added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 34f0a55 Jan 15, 2025
55 of 56 checks passed
@vinnyhoward vinnyhoward deleted the fix-12945-bottom-sheet-account-balance-hidden branch January 15, 2025 19:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team team-ramp issues related to Ramp features team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Account bottom sheet shows account balance even though balance was hidden
6 participants