-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(12945): privacy mode and account selection bottom sheet #12989
fix(12945): privacy mode and account selection bottom sheet #12989
Conversation
…ept when in send/swap flow
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 2abd70e Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ramp changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmation changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Issue: Privacy mode was not hiding account balances within the account selector bottom sheet at all
Solution: Have the account selector bottom sheet component subscribe to the
privacyMode
prop which hides the balance of all accounts, introduce thedisablePrivacyMode
route params so that the account selector bottom sheet can opt out of privacy mode completely for certain flows. Cases where this is needed is in the send flow and swap flow. We do not hide the balance when a user needs to switch between accounts when sending/swappingRelated issues
Fixes: #12945
Manual testing steps
Screenshots/Recordings
Send Flow
Swap Flow
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist