-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move battery profiling guides #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-fer
added
documentation
Improvements or additions to documentation.
doc required
This PR includes user-facing changes that need to be documented.
Do Not Merge
labels
Jul 4, 2024
Moved guides about battery profiling from NAN_045. Added information about the Offline Mode. NCD-943 and NCD-942. Signed-off-by: Grzegorz Ferenc <[email protected]>
greg-fer
force-pushed
the
doc_profiling_battery_guides
branch
from
July 16, 2024 11:25
0e0b6ca
to
da0bd17
Compare
@kylebonnici , can you have a look at the output:
And post comments in this PR if anything is incorrect? Thanks! |
kylebonnici
reviewed
Aug 16, 2024
doc/docs/profiling_battery.md
Outdated
|
||
The measurement data is automatically processed in the Nordic battery modeling software to make a single battery model file for each test temperature. | ||
|
||
1. After the temperature profiling at a given temperature is complete, follow the instructions in the application to charge the battery at room temperature before profiling at the next test temperature. When all the individual temperature models have been completed, they will be merged to generate the final battery model file. The final battery model is automatically saved as a JSON file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y model is automatically saved as a JSON file. -> y model is automatically saved as a JSON file and .inc.
kylebonnici
approved these changes
Aug 16, 2024
Signed-off-by: Grzegorz Ferenc <[email protected]>
As agreed with Eirik Slettahjell, Hilde Engelien-Lopes, and Ray Atotubo on Aug 20. Signed-off-by: Grzegorz Ferenc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Do Not Merge
doc required
This PR includes user-facing changes that need to be documented.
documentation
Improvements or additions to documentation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved guides about battery profiling from NAN_045. Added information about the Offline Mode.
NCD-943 and NCD-942.