[IMP]add moudule l10n_cn_account_voucher for v9. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @elicoidal |
| * Jeff/开阖软件 <[email protected]> | ||
| * Matt.Cai <[email protected]> | ||
| * hdjmd <[email protected]> | ||
| * Luke Zheng <[email protected]> |
There was a problem hiding this comment.
remove capitals from email address
|
LGTM |
|
@duanyp1991 @pedrobaeza could we move forward with this PR? |
| return False | ||
|
|
||
| def _get_exchange_rate(self, line): | ||
| ''' |
There was a problem hiding this comment.
Use double quotas for docstrings
|
ci is failing? |
| "installable": True, | ||
| "depends": [ | ||
| "account", | ||
| "l10n_cn_sequence_voucher", |
There was a problem hiding this comment.
Hi, Try to review this pr, but can't find related depends 'l10n_cn_sequence_voucher', where can i download it?
There was a problem hiding this comment.
True! @Rona111 can you add the dependency
@cysnake4713 Thanks for the review
|
cc @elicoidal @cysnake4713 I add the related depends of this module. |
| if not move.chinese_sequence_number: | ||
| sequence_id = self.env.ref( | ||
| 'l10n_cn_sequence_voucher\ | ||
| .sequence_journal_seq_transfer')[0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.