Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more bugfixes for roscore compatibility #6

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

jobafr
Copy link
Contributor

@jobafr jobafr commented Aug 29, 2024

changes:

  • return correct error when querying a missing parameter (previously, this would show up as a rospy.core.rosgraph.MasterError in the rospy API)
  • when param subscribers return (1, "", 0) instead of (), don't treat that as an error (apparently some clients do this)
  • make topic type mismatch a soft error, allow subscribing to * type (fixes rosbag record. upstream roscore allows using different types on the same topic. * is used when a subscriber doesn't care about the exact type, like rosbag. When a subscriber tries to connect to an incompatible publisher, this results in a warning on the client's side when using rospy, and is not handled by roscore. The previous behavior of ros-core-rs would be that the subscriber's API call fails entirely, which is different than what roscore does.)

@PatWie PatWie merged commit 3589921 into PatWie:main Aug 29, 2024
2 checks passed
@PatWie
Copy link
Owner

PatWie commented Aug 29, 2024

Super cool. Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants