more bugfixes for roscore compatibility #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
rospy.core.rosgraph.MasterError
in the rospy API)*
type (fixes rosbag record. upstream roscore allows using different types on the same topic.*
is used when a subscriber doesn't care about the exact type, like rosbag. When a subscriber tries to connect to an incompatible publisher, this results in a warning on the client's side when using rospy, and is not handled by roscore. The previous behavior of ros-core-rs would be that the subscriber's API call fails entirely, which is different than what roscore does.)