-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROS-O] add missing pluginlib dependency #252
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 19.89% 19.89%
=======================================
Files 5 5
Lines 1739 1739
=======================================
Hits 346 346
Misses 1393 1393 ☔ View full report in Codecov by Sentry. |
ping @henningkayser . |
Ping @henningkayser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't pluginlib also be added to CATKIN_DEPENDS?
CATKIN_DEPENDS lists dependencies forwarded to downstream packages. pluginlib is used for plugins, which usually don't have downstream dependencies. |
The uses of the pluginlib header are in cpp files and not the headers so I do not think it should be added for that reason. |
@nbbrooks Can you also merge, please? |
This is required to compile with debian's
pluginlib-dev
package which isolates the headers.The include is required here and here.