Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS-O] add missing pluginlib dependency #252

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Feb 22, 2024

This is required to compile with debian's pluginlib-dev package which isolates the headers.
The include is required here and here.

@auto-assign auto-assign bot requested a review from nbbrooks February 22, 2024 14:49
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.89%. Comparing base (8703caf) to head (3fc4537).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   19.89%   19.89%           
=======================================
  Files           5        5           
  Lines        1739     1739           
=======================================
  Hits          346      346           
  Misses       1393     1393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@v4hn
Copy link
Contributor Author

v4hn commented Feb 22, 2024

ping @henningkayser .

@rhaschke
Copy link

Ping @henningkayser

Copy link
Member

@nbbrooks nbbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't pluginlib also be added to CATKIN_DEPENDS?

@rhaschke
Copy link

rhaschke commented Nov 4, 2024

CATKIN_DEPENDS lists dependencies forwarded to downstream packages. pluginlib is used for plugins, which usually don't have downstream dependencies.

@nbbrooks
Copy link
Member

nbbrooks commented Nov 8, 2024

The uses of the pluginlib header are in cpp files and not the headers so I do not think it should be added for that reason.

@rhaschke
Copy link

rhaschke commented Nov 8, 2024

@nbbrooks Can you also merge, please?

@nbbrooks nbbrooks merged commit beaa5d8 into PickNikRobotics:master Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants