Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include py.typed file & port to pixi #52

Merged
merged 38 commits into from
May 23, 2024
Merged

include py.typed file & port to pixi #52

merged 38 commits into from
May 23, 2024

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented May 21, 2024

Checklist

  • Added a CHANGELOG.rst entry

@0xbe7a 0xbe7a requested a review from pavelzw May 21, 2024 11:47
pavelzw
pavelzw reviewed May 22, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pixi.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/multiregex/__init__.py Show resolved Hide resolved
src/ahocorasick.pyi Show resolved Hide resolved
@pavelzw
Copy link
Member

pavelzw commented May 22, 2024

also remove .flake8

pavelzw
pavelzw reviewed May 22, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@0xbe7a 0xbe7a requested a review from pavelzw May 23, 2024 12:17
@0xbe7a
Copy link
Contributor Author

0xbe7a commented May 23, 2024

image

PyPi has been configured and i have created a pypi env in this repo which is only accessible from main

pavelzw
pavelzw reviewed May 23, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
pixi.toml Show resolved Hide resolved
pavelzw
pavelzw reviewed May 23, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member

pavelzw commented May 23, 2024

you still need to replace

multiregex/multiregex/__init__.py

Line 46 in 1c85ebf

__version__ = "2.0.0"
with something like https://github.com/Quantco/polarify/blob/97fb1dadcbe17c69506a994f406720dad9fa07c4/polarify/__init__.py#L9-L14

@0xbe7a 0xbe7a merged commit af01871 into main May 23, 2024
9 checks passed
@0xbe7a 0xbe7a deleted the pixi-port branch May 23, 2024 13:52
@pavelzw pavelzw mentioned this pull request Jul 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelzw pavelzw pavelzw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xbe7a @pavelzw