Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android build/stage when no cook flavor is specified #74

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hach-que
Copy link
Member

@hach-que hach-que commented Dec 2, 2024

This makes Android stage/package to the normal directory name when no specific cook flavor is requested.

@hach-que
Copy link
Member Author

hach-que commented Dec 2, 2024

cc @JasperDeLaat94 I couldn't figure out how to add you as a reviewer on this pull request (GitHub doesn't let me pick your username), but since this is touching the Android cook flavor code, it'd be good if you could check that everything still works on your end before this gets merged.

@JasperDeLaat94 JasperDeLaat94 self-assigned this Dec 2, 2024
@JasperDeLaat94 JasperDeLaat94 self-requested a review December 2, 2024 12:08
Copy link
Collaborator

@JasperDeLaat94 JasperDeLaat94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works as intended; with and without specifying cook flavor.

@hach-que hach-que merged commit 449834b into main Dec 2, 2024
19 checks passed
@hach-que hach-que deleted the android-cook branch December 2, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants