-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Document macOS EOL release tags #20458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with a small organizational nit that I'm not attached to.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee BetsyMcPhail, needs platform reviewer assigned
doc/_release-notes/end_of_support.md
line 10 at r1 (raw file):
If you need to use these, you can use an old release of Drake. ## Python 3.10 (Wheel)
minor, the way the document headings read are a little confusing. Do you think it's worth having two subsections?
## Python Wheels
### Python 3.10
...
## Distributions
## Ubuntu 18.04 (Bionic)
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee BetsyMcPhail, needs platform reviewer assigned
doc/_release-notes/end_of_support.md
line 10 at r1 (raw file):
Previously, svenevs (Stephen McDowell) wrote…
minor, the way the document headings read are a little confusing. Do you think it's worth having two subsections?
## Python Wheels ### Python 3.10 ... ## Distributions ## Ubuntu 18.04 (Bionic) ...
whoops, sorry, ### Ubuntu 18.04 (Bionic)
as an h3 under the Distributions
h2, I cannot edit that
2db6c03
to
63f223c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@EricCousineau-TRI for platform review per schedule, please.
Reviewable status: LGTM missing from assignees BetsyMcPhail,EricCousineau-TRI(platform)
doc/_release-notes/end_of_support.md
line 10 at r1 (raw file):
Previously, svenevs (Stephen McDowell) wrote…
whoops, sorry,
### Ubuntu 18.04 (Bionic)
as an h3 under theDistributions
h2, I cannot edit that
Good point. I ran with it even further and reworked the overall layout. (I also moved Wheels down later on the page.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee BetsyMcPhail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees EricCousineau-TRI(platform),svenevs
Towards #20339.
+@svenevs or +@BetsyMcPhail for feature review, please.
This change is