Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Document macOS EOL release tags #20458

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 31, 2023

Towards #20339.

+@svenevs or +@BetsyMcPhail for feature review, please.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low release notes: none This pull request should not be mentioned in the release notes labels Oct 31, 2023
Copy link
Contributor

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: with a small organizational nit that I'm not attached to.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee BetsyMcPhail, needs platform reviewer assigned


doc/_release-notes/end_of_support.md line 10 at r1 (raw file):

If you need to use these, you can use an old release of Drake.

## Python 3.10 (Wheel)

minor, the way the document headings read are a little confusing. Do you think it's worth having two subsections?

## Python Wheels

### Python 3.10

...

## Distributions

## Ubuntu 18.04 (Bionic)

...

Copy link
Contributor

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, LGTM missing from assignee BetsyMcPhail, needs platform reviewer assigned


doc/_release-notes/end_of_support.md line 10 at r1 (raw file):

Previously, svenevs (Stephen McDowell) wrote…

minor, the way the document headings read are a little confusing. Do you think it's worth having two subsections?

## Python Wheels

### Python 3.10

...

## Distributions

## Ubuntu 18.04 (Bionic)

...

whoops, sorry, ### Ubuntu 18.04 (Bionic) as an h3 under the Distributions h2, I cannot edit that

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@EricCousineau-TRI for platform review per schedule, please.

Reviewable status: LGTM missing from assignees BetsyMcPhail,EricCousineau-TRI(platform)


doc/_release-notes/end_of_support.md line 10 at r1 (raw file):

Previously, svenevs (Stephen McDowell) wrote…

whoops, sorry, ### Ubuntu 18.04 (Bionic) as an h3 under the Distributions h2, I cannot edit that

Good point. I ran with it even further and reworked the overall layout. (I also moved Wheels down later on the page.)

Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: platform

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee BetsyMcPhail

Copy link
Contributor

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees EricCousineau-TRI(platform),svenevs

@jwnimmer-tri jwnimmer-tri merged commit 85fec76 into RobotLocomotion:master Nov 2, 2023
@jwnimmer-tri jwnimmer-tri deleted the doc-eol-tags branch November 2, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants