feat: ng 19 #12883
Open
feat: ng 19 #12883
+6,076
−5,596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
droshev
requested review from
mikerodonnell89 and
InnaAtanasova
as code owners
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 9bb9e08): https://fundamental-ngx-gh--pr12883-feat-ng19-2-qqeq5363.web.app (expires Thu, 02 Jan 2025 21:30:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
6 tasks
droshev
force-pushed
the
feat/ng19-2
branch
6 times, most recently
from
00a1186 to
c072000
Compare
Comment on lines
+1
to
3
| @use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap; | ||
| @use 'fundamental-styles/dist/avatar-group.css'; | ||
|
|
| @@ -22,7 +22,7 @@ export class CardCounterDirective implements OnInit, OnChanges, CssClassBuilder | |||
| * the status represented by the Object Status. | |||
| * can be one of the following: 'negative' | 'critical' | 'positive' | 'informative' | 'neutral' | |||
| */ | |||
| statusInput = input<ObjectStatus>('neutral', { alias: 'status' }); | |||
There was a problem hiding this comment.
I think we need the alias
Comment on lines
+1
to
+2
| @use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap; | ||
| @use 'fundamental-styles/dist/link.css'; |
Comment on lines
+1
to
+2
| @use '@angular/cdk/overlay-prebuilt.css'; | ||
| @use 'fundamental-styles/dist/message-toast.css'; |
Comment on lines
+1
to
+2
| @use 'fundamental-styles/dist/popover.css'; | ||
| @use '@angular/cdk/overlay-prebuilt.css'; |
| @@ -24,7 +24,8 @@ import { NestedListPopoverInterface } from './nested-list-popover.interface'; | |||
| templateUrl: './nested-list-popover.component.html', | |||
| styleUrl: './nested-list-popover.component.scss', | |||
| encapsulation: ViewEncapsulation.None, | |||
| changeDetection: ChangeDetectionStrategy.OnPush | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| standalone: false | |||
| @@ -31,7 +31,8 @@ import { NestedListInterface } from './nested-list.interface'; | |||
| template: ` <ng-content></ng-content> `, | |||
| // eslint-disable-next-line @angular-eslint/component-selector | |||
| selector: '[cxNestedList], [fdx-nested-list], ul[fdx-nested-list]', | |||
| providers: [contentDensityObserverProviders()] | |||
| providers: [contentDensityObserverProviders()], | |||
| standalone: false | |||
| @@ -10,7 +10,8 @@ import { NestedListComponent } from '../nested-list/nested-list.component'; | |||
| selector: 'fdx-prepared-nested-list', | |||
| templateUrl: './prepared-nested-list.component.html', | |||
| encapsulation: ViewEncapsulation.None, | |||
| changeDetection: ChangeDetectionStrategy.OnPush | |||
| changeDetection: ChangeDetectionStrategy.OnPush, | |||
| standalone: false | |||
| @@ -1,7 +1,8 @@ | |||
| import { Directive, HostBinding } from '@angular/core'; | |||
|
|
|||
| @Directive({ | |||
| selector: '[cxSideNavButton], [fdx-side-nav-button]' | |||
| selector: '[cxSideNavButton], [fdx-side-nav-button]', | |||
| standalone: false | |||
| @@ -3,7 +3,8 @@ import { NestedListComponent } from '@fundamental-ngx/cx/nested-list'; | |||
|
|
|||
| @Directive({ | |||
| // eslint-disable-next-line @angular-eslint/directive-selector | |||
| selector: '[cxSideNavigationUtility], [fdx-side-nav-utility]' | |||
| selector: '[cxSideNavigationUtility], [fdx-side-nav-utility]', | |||
| standalone: false | |||
There was a problem hiding this comment.
no it can't, in angular 19 default for standalone is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12741
BREAKING CHANGES: angular 19 support