Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NS1: update ns1 for new txt handling #2644

Merged
merged 2 commits into from
Nov 22, 2023
Merged

NS1: update ns1 for new txt handling #2644

merged 2 commits into from
Nov 22, 2023

Conversation

costasd
Copy link
Contributor

@costasd costasd commented Nov 21, 2023

  • update auditrecords for succeeding tests
    • multiple segments not needed anymore. This was there to cover an edge case of a user setting segments in the dnsconfig file
    • strings can be longer than 255 octets, but not 0.
  • update ns1 txt handling. No need for segmenting anymore, ns1 api handles this transparently.

@costasd
update ns1 for new txt handling
dbbf40b 
* update auditrecords for succeeding tests
  * multiple segments not needed anymore
  * strings can be longer than 255 otxtes
* update ns1 txt handling.
    No need for segmenting anymore, api handles this transparently.
@costasd costasd mentioned this pull request Nov 21, 2023
Merged
@tlimoncelli tlimoncelli changed the title update ns1 for new txt handling NS1: update ns1 for new txt handling Nov 22, 2023
@tlimoncelli tlimoncelli merged commit d14588d into StackExchange:tlim_newtxt_minimal Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlimoncelli tlimoncelli tlimoncelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@costasd @tlimoncelli