🐛 fix: keep new event on grid during save #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that-one-arab
changed the title
that-one-arab
force-pushed
the
bug_keep_new_event_on_grid_during_save
branch
from
4e85f7f to
2105935
Compare
…Event() the event schema is meant to more closely represent the data model. optimistic shouldn't be part of the data model
for consistency with other boolean naming
without upgrading the target, TypeScript is unable to iterate through a generator without the --downlevelIteration flag or a --target of es2015 or higher. This issue arises because the yield* expression is used to delegate to another generator function, and TypeScript needs to be able to iterate through the generator.
tyler-dane
reviewed
Dec 23, 2024
There was a problem hiding this comment.
I'm gonna do a little more cleanup and QA, but this is in pretty good shape.
Thanks, @that-one-arab!
Thanks @tyler-dane ! I'll keep an eye on the cleanups you're doing, learn new things in the process. |
Removed TODO comment. We're probably better off sticking with passing ids to conform to the codebase
that-one-arab
force-pushed
the
bug_keep_new_event_on_grid_during_save
branch
from
030b763 to
6a57e09
Compare
|
@tyler-dane I added additional commits that continues from where you left off |
instead, we're deriving this value by the id itself. if it's prefixed with "optimistic", we know it's an optimistic event. by removing this from the schema, we prevent ui fields from creeping into our database and cut down on the parsing we have to do in the redux slice/sagas
previously we swapped the id key, but we also have to swap the nested id value in order to completely replace the optimistic event with the actual event
|
Just made a few more tweaks, but we can consider this done! I'm going to hold off on merging until after I've had the chance to deploy it to prod. |
|
Alright, deployed and tested. Congrats on your first PR! 🙌 |
This was referenced Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this
Uses an optimistic UI rendering approach.
I believe Optimistic UI approach is the simplest and easiest solution under the current circumstances.
There are a couple of edge cases that needs to be handled that I believed were out of scope of this issue, but should be tackled in the future; during the timespan where the optimistically generated event is created and the HTTP request returns a response from the server:
We can tackle these separately