Audio pipeline buffers to std::span #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellar-aria
added
the
refactor
m-m-adams
reviewed
Jan 13, 2025
|
There's some issues with the last two functional commits (output and modfx), I'm going to re-review them. |
stellar-aria
force-pushed
the
audio-spans
branch
from
48ebb9f to
6ecedd0
Compare
stellar-aria
force-pushed
the
audio-spans
branch
from
6ecedd0 to
8fb27d8
Compare
|
I've tested and updated this now |
m-m-adams
approved these changes
Jan 18, 2025
| else { | ||
| volumePostFX += (volumeAdjustment >> 2); | ||
| } | ||
| volumePostFX += (outputType == OutputType::AUDIO) ? multiply_32x32_rshift32_rounded(volumeAdjustment, 471633397) |
There was a problem hiding this comment.
nit but this is a bit messy for a ternary imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies most of the audio pipeline buffer parameters to std::spans. Notably does not touch Voice or FilterSet.
It's been tested on a number of problem songs and doesn't have any sound changes, now. Recording/monitoring should probably be tested too.