Ignore manifest check for l10n_generic_coa in 17.0 and above #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Odoo 17.0 they removed the module `l10n_generic_coa`, but they kept its directory and with only the __init__.py file. This causes manifest check to fail if `strict` was `True`. This commit causes `addons_config` to ignore this module for 17.0 and above.
|
To reproduce the "issue" run this command for a The |
|
I think the leftover is more a bug than something intentional. I'm on travel for the Spanish OCA days, where I will meet with some people from Odoo SA. I'll check with them about this. |
|
Thanks @pedrobaeza , anyways I created a PR to remove that file from odoo/odoo |
|
Closing as the upstream has been merged. Thanks for the follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Odoo 17.0 they removed the module
l10n_generic_coa, but they kept its directory and with only the init.py file.This causes manifest check to fail if
strictwasTrue.This commit causes
addons_configto ignore this module for 17.0 and above.