Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore manifest check for l10n_generic_coa in 17.0 and above #609

Closed
wants to merge 3 commits into from
Closed

Ignore manifest check for l10n_generic_coa in 17.0 and above #609

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36a22d4
Exception for removed module: l10n_generic_coa
obayit May 3, 2024
aebc2d4
Fix formatting
obayit May 3, 2024
637b353
Fix formatting
obayit May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/doodbalib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,25 @@ def addons_config(filtered=True, strict=False):
for addon in found:
if not os.path.isdir(addon):
continue
addon_name = os.path.basename(addon)
skip_coa_17 = False
try:
odoo_version_float = float(ODOO_VERSION)
skip_coa_17 = (
odoo_version_float >= 17 and addon_name == "l10n_generic_coa"
)
except Exception:
pass
manifests = (os.path.join(addon, m) for m in MANIFESTS)
if not any(os.path.isfile(m) for m in manifests):
if not any(os.path.isfile(m) for m in manifests) and not skip_coa_17:
missing_manifest.add(addon)
logger.debug(
"Skipping '%s' as it is not a valid Odoo " "module", addon
)
continue
logger.debug("Registering addon %s", addon)
addon = os.path.basename(addon)
config.setdefault(addon, set())
config[addon].add(repo)
config.setdefault(addon_name, set())
config[addon_name].add(repo)
# Fail now if running in strict mode
if strict:
error = []
Expand Down
Loading