feat(dart_frog_cli): add host option to dev
#1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
requested review from
felangel,
wolfenrain,
erickzanardo and
alestiago
as code owners
alestiago
previously approved these changes
Oct 18, 2023
packages/dart_frog_cli/lib/src/commands/dev/templates/dart_frog_dev_server_bundle.dart
Outdated
Show resolved
Hide resolved
packages/dart_frog_cli/lib/src/daemon/domain/dev_server_domain.dart
Outdated
Show resolved
Hide resolved
renancaraujo
force-pushed
the
renan/add-host-option-to-cli
branch
from
a56cfbe to
a4b1426
Compare
renancaraujo
force-pushed
the
renan/add-host-option-to-cli
branch
from
a4b1426 to
1764b5b
Compare
alestiago
previously approved these changes
Oct 30, 2023
packages/dart_frog_cli/lib/src/dev_server_runner/dev_server_runner.dart
Outdated
Show resolved
Hide resolved
packages/dart_frog_cli/lib/src/dev_server_runner/dev_server_runner.dart
Outdated
Show resolved
Hide resolved
|
I think we should also edit the output message, currently running Running on http://localhost:8080 (0.1s)instead of: Running on http://<host>:8080 (0.1s) |
…nner.dart Co-authored-by: Alejandro Santiago <[email protected]>
renancaraujo
force-pushed
the
renan/add-host-option-to-cli
branch
2 times, most recently
from
f8beca9 to
a99a717
Compare
renancaraujo
force-pushed
the
renan/add-host-option-to-cli
branch
from
f1952e7 to
0888a20
Compare
alestiago
approved these changes
Oct 31, 2023
alestiago
previously approved these changes
Oct 31, 2023
…nner.dart Co-authored-by: Alejandro Santiago <[email protected]>
alestiago
approved these changes
Oct 31, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Follows #1113
Closes #912
Type of Change