YoastCS: more code structure rules #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | -- | Yst Video | -- | Yst Premium | 1 | Yst Free | -- Note: this rule was previously already "silently" enforced via clean-up sweeps.
This sniff will throw an error when a closure is more than 10 lines long. Note: blank lines and comment-only lines are not includes in the closure line count. Related to 303 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | 1 error (11 lines) | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | 1 error (17 lines) | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | 1 error (16 lines) | Yst Video | -- | Yst Premium | 1 error (15 lines) | Yst Free | 3 errors (21/25/37 lines)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YoastCS rules: enforce a consistent OO structure order
Related to #303
Impact on Yoast packages:
Note: this rule was previously already "silently" enforced via clean-up sweeps.
YoastCS rules: disallow long closures
This sniff will throw an error when a closure is more than 10 lines long.
Note: blank lines and comment-only lines are not includes in the closure line count.
Related to #303
Impact on Yoast packages: