Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YoastCS: more code structure rules #362

Merged
merged 2 commits into from
Dec 14, 2023
Merged

YoastCS: more code structure rules #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a2f448
YoastCS rules: enforce a consistent OO structure order
jrfnl Sep 18, 2023
02d8905
YoastCS rules: disallow long closures
jrfnl Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Yoast/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,32 @@
SNIFFS RELATED TO CODE STRUCTURING
#############################################################################
-->
<!-- CS/QA: Enforce consistent order of OO structures. -->
<rule ref="SlevomatCodingStandard.Classes.ClassStructure">
<properties>
<property name="groups" type="array">
<element value="uses"/>
<element value="enum cases"/>
<element value="constants"/>
<element value="properties"/>
<element value="methods"/>
</property>
</properties>
</rule>

<!-- CS: ensure exactly one blank line before each property declaration. -->
<rule ref="Squiz.WhiteSpace.MemberVarSpacing"/>

<!-- CS/QA: Forbid the use long closures. Use named functions instead. -->
<rule ref="Universal.FunctionDeclarations.NoLongClosures">
<properties>
<property name="maxLines" value="10"/>
</properties>

<!-- Disable the warning, only have an error. -->
<exclude name="Universal.FunctionDeclarations.NoLongClosures.ExceedsRecommended"/>
</rule>


<!--
#############################################################################
Expand Down