Improve EUDIW interop #48
Conversation
This may apply to request objects itsef, or JSON Web Key Sets, client metadata.
| @@ -240,35 +240,3 @@ data class AuthenticationRequestParameters( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // restricted to internal as there is no reason to make this public for now | |||
There was a problem hiding this comment.
Why are we completely removing those instead of just renaming them?
There was a problem hiding this comment.
Because with this class you don't see the serial name of the property at a glance (which is quite useful for OID obejcts). Additionally, it is different from all other classes then. Also, nobody needs the serial names.
vclib-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidc/JsonWebKeySet.kt
Outdated
Show resolved
Hide resolved
| val constraintFields = attributeConstraint + typeConstraint | ||
| val schemaReference = SchemaReference( | ||
| requestOptions.credentialScheme?.schemaUri ?: "https://example.com" |
|
As a general remark which does not need to be addressed here: would you mind upgrading to the latest conventions (1.9.23+20240409+1) for automated version catalog publishing? |
This should be handled in a separate PR imho |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Updates the implementation of OIDC SIOPv2 and OpenID for Verifiable Presentations, refactors interfaces of public classes to further improve the interoperability with EUDIW reference implementation.
These changes should allow Wallet implementations to generate a correct response to EUDIW verifier at https://verifier.eudiw.dev/home
Fixes #47