Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for end-to-end test (using Docker) #58

Merged
merged 20 commits into from
Oct 11, 2024

Conversation

hannahbast
Copy link
Member

@hannahbast hannahbast commented Sep 22, 2023

This workflow performs the following end-to-end test using the Docker setup:

  1. Check out the code
  2. Build a Docker image using the Dockerfile provided by the code
  3. Download the PBF for Malta and built a TTL for it
  4. Build a QLever index from the TTL, start a server, and query for the number of geometries

@hannahbast hannahbast changed the title Add workflow that builds Docker image and runs it Add workflow for end-to-end test (using Docker) Sep 23, 2023
@patrickbr
Copy link
Member

patrickbr commented Jan 12, 2024

Thanks, @hannahbast ! Looking over the Dockerfile, we did not fully understand the additional benefit of spinning up a QLever instance and filling it with the generated TTL. As we understand it, this mainly tests (1) if the generated TTL is valid, and (2) whether a roughly expected number of geometries has been written. But isn't (1) already performed in the Build TTL for Malta and check its validity step, and couldn't (2) be achieved by a simple grep | wc -l, without adding the additional QLever dependency?

@patrickbr patrickbr force-pushed the add-build-workflows branch from 682a577 to 17c6f00 Compare October 11, 2024 13:23
@patrickbr patrickbr force-pushed the add-build-workflows branch from 17c6f00 to daf25fa Compare October 11, 2024 13:50
@patrickbr patrickbr merged commit f548c46 into master Oct 11, 2024
5 checks passed
@patrickbr patrickbr deleted the add-build-workflows branch October 11, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants