Handle "predictive back" / ActivityTransitionAnimation deprecation in API34 #14558
Labels
Milestone
Comments
|
Predictive back gesture reference: https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture |
|
We also need to fix the onBackPressed() deprecation in #12364 . |
mikehardy
changed the title
|
PR #13586 looks like the proper way to go about things - sad (word directed at myself) that the PR has sat so long and accumulated some conflicts! It looks good and should be considered for fixup + merge to fix this for real |
5 tasks
|
Just adding a quick note here that one item has been provisionally handled, so it may not show up in the deprecation scans anymore, but it needs a more thorough handling as it's a temporary patch: |
This comment has been minimized.
This comment has been minimized.
5 tasks
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
API34 adds new predictive back behavior, which implies that the transition animation overrides for activity stack change animations now need to know whether the animation override is for activity open or close, whereas we override both as a unit without thought
This needs a solution before the deprecated methods go away, likely in the form of plumbing through (via a new parameter) the idea of whether the call site intended to override open, close, or both animations. For backwards compatibility this will likely need to be a Compat interface (or interfaces) to replace the current implementation
Originally posted by @mikehardy in #14556 (comment)
The text was updated successfully, but these errors were encountered: