-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/sensors: Add Velocity sensor type to UORB #15293
Conversation
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. While it provides a basic summary and mentions testing, it lacks crucial details required for proper review. Here's a breakdown of the missing information:
Example of improved descriptions for some sections: Summary:
Impact:
Testing:
By providing more specific information as demonstrated above, the PR will be much clearer and easier for reviewers to evaluate, ultimately leading to a quicker and smoother integration process. |
shouldn't this be a velocity sensor ? "Velocity" is a vector quantity, so it can be signed, "speed" can't. EDIT: FS3000 is Air Velocity Sensor Module. Velocity and speed are not the same thing (but often confused and used interchangeably) |
Good point @raiden00pl :-) The same way we use accelerometers to measure acceleration :-) |
This patch adds support for velocity measurement sensors. I plan to use it as a generic velocity type to be used for Renesas FS3000 (Air Velocity Flow). Signed-off-by: Alan C. Assis <[email protected]>
0e127fd
to
4a4b1ff
Compare
Good point, I'll update it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you @acassis :-)
After this PR is merged, next is apache/nuttx-apps#2908.
Summary
This patch adds support for velocity measurement sensors. I plan to use it as a generic speed type to be used for Renesas FS3000 (Air Velocity Flow).
Related PR: apache/nuttx-apps#2908
Impact
Now uORB will support Velocity sensors
Testing
Tested with FS3000 air velocity flow sensor