-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing/sensortest: Add support to Velocity Sensors #2908
Conversation
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details in several sections. Here's a breakdown of what's missing and how it can be improved: Summary:
Example of a better Summary:
Impact:
Example of a better Impact:
Testing:
Example of a better Testing:
In short, the provided PR description is a starting point but needs significant expansion to meet the NuttX requirements. Provide specific details, logs, and consider all the impact categories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @acassis :-) Please take a look at CI build complains :-P
It is expected because this PR depends on apache/nuttx#15293 be merged first |
Signed-off-by: Alan C. Assis <[email protected]>
a7f0943
to
155682f
Compare
Okay apache/nuttx#15293 is merged, I have restarted CI, should work this time :-) Thanks @acassis :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All clear, thank you @acassis ! :-)
Summary
Add support to Speed Sensors on sensortest
Depends on: apache/nuttx#15293
Impact
User will be able to use speed sensors
Testing
FS3000