Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #798

Merged
merged 34 commits into from
Jan 23, 2025
Merged

Update dependencies #798

merged 34 commits into from
Jan 23, 2025

Conversation

mauch
Copy link
Contributor

@mauch mauch commented Jan 17, 2025

Update dependencies to deal with dependabot reccomendations and to prepare for future upgrades. The updates of Numpy and Pandas required some changes to bits of the code to deal with deprectaions.

Also update the javascript dependencies and run npm audit fix. This has made no difference to the web interface as far as I can tell.

This closes all the current dependabot PRs: #682 #681 #680 #679 #677 #675 #674 #673 #671 #670 #669 #668 #663 #659 #635

dependabot bot and others added 19 commits July 18, 2022 17:21
@dependabot
Bump jquery-ui from 1.13.1 to 1.13.2
f4a8917 
Bumps [jquery-ui](https://github.com/jquery/jquery-ui) from 1.13.1 to 1.13.2.
- [Release notes](https://github.com/jquery/jquery-ui/releases)
- [Commits](jquery/jquery-ui@1.13.1...1.13.2)

---
updated-dependencies:
- dependency-name: jquery-ui
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump minimatch from 3.0.4 to 3.1.2
9ab3f60 
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
- [Release notes](https://github.com/isaacs/minimatch/releases)
- [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump moment from 2.29.2 to 2.29.4
fe26bbb 
Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.2...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump decode-uri-component from 0.2.0 to 0.2.2
bb873a9 
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump json5 from 2.2.1 to 2.2.3
7ab969a 
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@mauch
Update python packages and poetry.lock
9ad64d8
@mauch
Update javascript dependencies and regnerate lock file.
e431e59
@mauch
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/decode-u…
234cdfc 
…ri-component-0.2.2' into update-deps
@mauch
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/json5-2.…
bf69131 
…2.3' into update-deps
@mauch
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/moment-2…
2fcb0d7 
….29.4' into update-deps
@mauch
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/minimatc…
2c7f001 
…h-3.1.2' into update-deps
@mauch
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/jquery-u…
f173155 
…i-1.13.2' into update-deps
@mauch
Merge remote-tracking branch 'origin/dependabot/npm_and_yarn/jquery-u…
075baca 
…i-1.13.2' into update-deps
@mauch
Merge branch 'update-deps' of https://github.com/askap-vast/vast-pipe…
8bb4979 
…line into update-deps
@mauch
Fix broken merge
24f6804
@mauch
Update some dependencies to get rid of deprecation warnings.
5dabae0
@mauch
Fix deprecations due to numpy and pandas upgrade
a17e7ee
@mauch
Run npm audit fix.
96782e9
@mauch
Get tests to pass.
a06bffe
@mauch mauch added dependencies Pull requests that update a dependency file v2.0 labels Jan 17, 2025
@mauch mauch self-assigned this Jan 17, 2025
@mauch mauch marked this pull request as ready for review January 21, 2025 04:47
@mauch mauch requested a review from ddobie January 21, 2025 04:47
mauch and others added 3 commits January 23, 2025 10:19
@mauch @ddobie
Update pyproject.toml
14f57a8 
Co-authored-by: Dougal Dobie <[email protected]>
@mauch @ddobie
Update pyproject.toml
fb24d40 
Co-authored-by: Dougal Dobie <[email protected]>
@mauch @ddobie
Update vast_pipeline/_version.py
16e98d0 
Co-authored-by: Dougal Dobie <[email protected]>
@mauch
Copy link
Contributor Author

mauch commented Jan 22, 2025

I don't know if it's a problem on the compute end or a problem with the updates, but it doesn't seem possible to launch things from the website. E.g. hitting the "Generate arrow files" button puts a task in the queue (see admin page) but that doesn't ever seem to be executed.

Could be that qcluster is breaking, or just that qcluster isn't actually running on mpc

Yes - so I wasn't running qcluster. I have it running now - and checked the create measurement arrow task which seems to work from the webpage.
I've left it running so you can try playing around with it as well.

@mauch
Copy link
Contributor Author

mauch commented Jan 22, 2025

The eta-V analysis page seems to be broken. To reproduce, go to the Sources page, do a query with some parameters (see below for example) and then in the top right of the results tab hit "go to eta-V analysis". It's probably a bokeh version problem or something like that, but I'm not sure off the top of my head

OK. After an epic battle with Bokeh - I think it is working as before now. I also took the oppurtunity to fix the TNS equry in the external search results panel of the eta-V page.

@mauch
Copy link
Contributor Author

mauch commented Jan 22, 2025

Just another thought - how are we going to handle the changelog for this?

Good point! I was going to mention this when we met the other day but forgot.
I've updated the changelog and put a 'V2' in front of the comments. When it comes time to merge the v2.0 branch with dev we'll hopefully have a final v1.x dev branch and can sort out the changelog file at that point by leaving all the V2 changes under the Unreleased heading (everything in V1 will be in a relase at that point). You recon that will work?

@mauch mauch requested a review from ddobie January 22, 2025 23:42
@ddobie
Copy link
Contributor

ddobie commented Jan 23, 2025

Yeah that makes sense!

Only slightly confusing thing is that it'll be linking PRs that are merging onto a branch that isn't dev, but I don't think that's actually a problem

@ddobie
Copy link
Contributor

ddobie commented Jan 23, 2025

I've played around and everything seems to be okay!

@mauch mauch merged commit 585dc44 into v2.0 Jan 23, 2025
4 checks passed
@mauch mauch deleted the update-deps branch January 23, 2025 04:20
This was referenced Jan 23, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddobie ddobie ddobie approved these changes

Assignees

@mauch mauch

Labels
dependencies Pull requests that update a dependency file v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauch @ddobie