refactor(autoware_pointcloud_preprocessor): rework dual return outlier filter parameters #8475

vividf · 2024-08-14T14:59:08Z

Description

This PR includes the following changes

Remove the default parameters for the dual return outlier filter node.
Add parameter, launch file, and parameters schema for the node.
Change the name nodelet to node.

A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.

How was this PR tested?

ros2 launch autoware_pointcloud_preprocessor dual_return_outlier_filter_node.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: vividf <[email protected]>

github-actions · 2024-08-14T14:59:25Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

Signed-off-by: vividf <[email protected]>

github-actions · 2024-08-15T02:28:34Z

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8475/
Modified URLs:

https://autowarefoundation.github.io/autoware.universe/pr-8475/sensing/autoware_pointcloud_preprocessor/dual-return-outlier-filter/

codecov · 2024-08-15T02:39:33Z

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 25.39%. Comparing base (6a24683) to head (7be1c2e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...outlier_filter/dual_return_outlier_filter_node.cpp	0.00%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8475      +/-   ##
==========================================
- Coverage   26.17%   25.39%   -0.79%     
==========================================
  Files        1298     1344      +46     
  Lines       96983    99723    +2740     
  Branches    39182    40343    +1161     
==========================================
- Hits        25385    25320      -65     
- Misses      68992    71761    +2769     
- Partials     2606     2642      +36

Flag	Coverage Δ		*Carryforward flag
differential	`22.53% <0.00%> (?)`
total	`25.12% <ø> (-1.06%)`	⬇️	Carriedforward from 7e329dc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sensing/autoware_pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_node.cpp

knzo25

Type inconsistencies

Signed-off-by: vividf <[email protected]>

badai-nguyen · 2024-08-23T15:13:56Z

@vividf
Since this filter is used in a x2 product so this PR should be merged after tier4/aip_launcher#285 merging

vividf · 2024-09-03T02:18:05Z

@knzo25 kindly ping

…arameter

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json

knzo25

Please pay attention to the details in your PRs. I seem to be making the same comments over and over

Signed-off-by: vividf <[email protected]>

vividf · 2024-09-18T02:25:56Z

@knzo25 Thanks for the review 👍 I fixed them!

knzo25

Once again, please re-read what you submit before requesting a review

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json

…tlier_filter_node.schema.json Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>

Signed-off-by: vividf <[email protected]>

knzo25 · 2024-09-30T00:54:03Z

@vividf
Not for this PR, but there are some things that could be improved in this package at a first glance.
Using the map of modes to integers should be instead to an enum.
Parameters that only apply to a single mode could have a more descriptive name that makes it obvious what you are referring to

…arameter

knzo25

Left a comment. Probably after that one we can merge

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json

Signed-off-by: vividf <[email protected]>

…arameter

knzo25

LGTM

…arameter

…r filter parameters (autowarefoundation#8475) * feat: rework dual return outlier filter parameters Signed-off-by: vividf <[email protected]> * chore: fix readme Signed-off-by: vividf <[email protected]> * chore: change launch file name Signed-off-by: vividf <[email protected]> * chore: fix type Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> * chore: change boundary Signed-off-by: vividf <[email protected]> * chore: fix boundary Signed-off-by: vividf <[email protected]> * chore: fix json schema Signed-off-by: vividf <[email protected]> * Update sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> * chore: fix grammar error Signed-off-by: vividf <[email protected]> * chore: fix description for weak_first_local_noise_threshold Signed-off-by: vividf <[email protected]> * chore: change minimum and maximum to float Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Signed-off-by: prakash-kannaiah <[email protected]>

feat: rework dual return outlier filter parameters

6795470

Signed-off-by: vividf <[email protected]>

github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 14, 2024

chore: fix readme

b03a5c5

Signed-off-by: vividf <[email protected]>

github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 14, 2024

chore: change launch file name

17c147f

Signed-off-by: vividf <[email protected]>

vividf marked this pull request as ready for review August 15, 2024 02:23

vividf requested review from amc-nu, badai-nguyen, drwnz, knzo25, kyoichi-sugahara, meliketanrikulu, miursh, YoshiRi and yukkysaito as code owners August 15, 2024 02:23

vividf self-assigned this Aug 15, 2024

vividf added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 15, 2024

badai-nguyen added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Aug 15, 2024

knzo25 reviewed Aug 20, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_node.cpp Outdated Show resolved Hide resolved

knzo25 reviewed Aug 20, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_node.cpp Outdated Show resolved Hide resolved

knzo25 requested changes Aug 20, 2024

View reviewed changes

chore: fix type

9a6d34c

Signed-off-by: vividf <[email protected]>

vividf requested a review from knzo25 August 20, 2024 09:04

vividf added 2 commits August 20, 2024 18:09

chore: add boundary

1da8e1b

Signed-off-by: vividf <[email protected]>

chore: change boundary

efbc23c

Signed-off-by: vividf <[email protected]>

badai-nguyen mentioned this pull request Aug 23, 2024

fix: add default missing params tier4/aip_launcher#285

Merged

Merge branch 'main' into refactor/rework_dual_return_outlier_filter_p…

72c94dc

…arameter

github-actions bot added the tag:require-cuda-build-and-test label Sep 10, 2024

knzo25 reviewed Sep 10, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json Outdated Show resolved Hide resolved

knzo25 reviewed Sep 10, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json Outdated Show resolved Hide resolved

knzo25 reviewed Sep 10, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json Outdated Show resolved Hide resolved

knzo25 reviewed Sep 10, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json Outdated Show resolved Hide resolved

knzo25 requested changes Sep 10, 2024

View reviewed changes

vividf added 2 commits September 18, 2024 10:01

chore: fix boundary

b122386

Signed-off-by: vividf <[email protected]>

chore: fix json schema

10e77aa

Signed-off-by: vividf <[email protected]>

vividf requested a review from knzo25 September 18, 2024 02:25

knzo25 requested changes Sep 18, 2024

View reviewed changes

vividf and others added 3 commits September 18, 2024 15:34

Update sensing/autoware_pointcloud_preprocessor/schema/dual_return_ou…

ea0e636

…tlier_filter_node.schema.json Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>

chore: fix grammar error

0d6b0bf

Signed-off-by: vividf <[email protected]>

chore: fix description for weak_first_local_noise_threshold

76f9ef6

Signed-off-by: vividf <[email protected]>

vividf requested a review from knzo25 September 18, 2024 07:52

Merge branch 'main' into refactor/rework_dual_return_outlier_filter_p…

498cfd1

…arameter

knzo25 requested changes Sep 30, 2024

View reviewed changes

sensing/autoware_pointcloud_preprocessor/schema/dual_return_outlier_filter_node.schema.json Outdated Show resolved Hide resolved

chore: change minimum and maximum to float

2941451

Signed-off-by: vividf <[email protected]>

vividf requested a review from knzo25 September 30, 2024 06:46

Merge branch 'main' into refactor/rework_dual_return_outlier_filter_p…

7e329dc

…arameter

knzo25 approved these changes Oct 1, 2024

View reviewed changes

Merge branch 'main' into refactor/rework_dual_return_outlier_filter_p…

7be1c2e

…arameter

vividf enabled auto-merge (squash) October 1, 2024 11:14

vividf merged commit 6fccdf5 into autowarefoundation:main Oct 1, 2024
32 checks passed

vividf deleted the refactor/rework_dual_return_outlier_filter_parameter branch December 26, 2024 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(autoware_pointcloud_preprocessor): rework dual return outlier filter parameters #8475

refactor(autoware_pointcloud_preprocessor): rework dual return outlier filter parameters #8475

vividf commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 15, 2024

codecov bot commented Aug 15, 2024 •

edited

Loading

knzo25 left a comment

badai-nguyen commented Aug 23, 2024 •

edited

Loading

vividf commented Sep 3, 2024

knzo25 left a comment

vividf commented Sep 18, 2024

knzo25 left a comment

knzo25 commented Sep 30, 2024

knzo25 left a comment

knzo25 left a comment

refactor(autoware_pointcloud_preprocessor): rework dual return outlier filter parameters #8475

refactor(autoware_pointcloud_preprocessor): rework dual return outlier filter parameters #8475

Conversation

vividf commented Aug 14, 2024 • edited Loading

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

github-actions bot commented Aug 14, 2024 • edited Loading

github-actions bot commented Aug 15, 2024

codecov bot commented Aug 15, 2024 • edited Loading

Codecov Report

knzo25 left a comment

Choose a reason for hiding this comment

badai-nguyen commented Aug 23, 2024 • edited Loading

vividf commented Sep 3, 2024

knzo25 left a comment

Choose a reason for hiding this comment

vividf commented Sep 18, 2024

knzo25 left a comment

Choose a reason for hiding this comment

knzo25 commented Sep 30, 2024

knzo25 left a comment

Choose a reason for hiding this comment

knzo25 left a comment

Choose a reason for hiding this comment

vividf commented Aug 14, 2024 •

edited

Loading

github-actions bot commented Aug 14, 2024 •

edited

Loading

codecov bot commented Aug 15, 2024 •

edited

Loading

badai-nguyen commented Aug 23, 2024 •

edited

Loading