fix: add default missing params #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
badai-nguyen
commented
Aug 23, 2024
•
badai-nguyen
commented
- This PR to add missing default params which will be removed by refactor(autoware_pointcloud_preprocessor): rework dual return outlier filter parameters autowarefoundation/autoware.universe#8475
Signed-off-by: badai-nguyen <[email protected]>
vividf
requested changes
Aug 26, 2024
There was a problem hiding this comment.
It seems that the parameter max_azimuth_diff is missing in the config and in https://github.com/tier4/aip_launcher/blob/tier4/universe/aip_x2_launch/launch/pandar_node_container.launch.py
Signed-off-by: badai-nguyen <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.