Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-266: use GroupAccessRequestNotificationV2 #1627

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

davidangb
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/CORE-266

What:

When sending a group access request notification, use GroupAccessRequestNotificationV2 instead of the deprecated GroupAccessRequestNotification. This enforces, in code, that notifications only use a single reply-to address.

Context of the overall rollout plan to adopt the SendGrid v3 APIs by February 10:

  1. [DONE] CORE-266: all email notifications use a single Reply-To address thurloe#369, which ensures all email notifications use a single reply-to~
  2. [DONE] CORE-235, CORE-266: re-enable sendgrid-java 4.10.3 and corresponding syntax changes thurloe#368, which adopts the latest sendgrid-java and v3 APIs
  3. [DONE] Modify workbench-libs to deprecate the GroupAccessRequestNotification used by Sam which allows multiple reply-tos; provide a replacement GroupAccessRequestNotificationV2 that only allows a single reply-to. See CORE-266: enforce a single reply-to address on group-access-request notifications workbench-libs#1717 (this PR)
  4. [DONE] Support the new GroupAccessRequestNotificationV2 model in Thurloe. See CORE-235: support GroupAccessRequestNotificationV2 notifications thurloe#372
  5. [this PR] Use the new GroupAccessRequestNotificationV2 model in Sam. After this step, Thurloe would no longer ignore the reply-to value sent by Sam; Sam would once again be in control of the reply-to.
  6. Remove support for the deprecated GroupAccessRequestNotification from Thurloe
  7. Delete the deprecated GroupAccessRequestNotification from workbench-libs

PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@davidangb davidangb marked this pull request as ready for review January 17, 2025 18:34
@davidangb davidangb requested a review from a team as a code owner January 17, 2025 18:34
@davidangb davidangb requested review from dvoet and samanehsan January 17, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants