[sync] 2022/11/28 #415
Merged
[sync] 2022/11/28 #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to #1319 Co-authored-by: Anthony Sansone <[email protected]>
Fixes dart-lang/site-www#4166 Co-authored-by: Anthony Sansone <[email protected]>
Co-authored-by: Anthony Sansone <[email protected]>
From 1.30 changelog: - New lint: `enable_null_safety` - New lint: `library_annotations` - Miscellaneous documentation improvements
Ensuring that the link doesn't go to 404, instead it'll go to the bug that we should write the page. See dart-lang/site-www#4361 Hopefully, this helps us not forget to write the page, and helps users highlight it if we do. It's certainly better than having a 404.
Bumps [site-shared](https://github.com/dart-lang/site-shared) from `cbd9b39` to `3f55d07`. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dart-lang/site-shared/commit/3f55d07704b43696ee36ac281a364d4f3faa19d2"><code>3f55d07</code></a> Remove unused scripts after new infrastructure (<a href="https://github-redirect.dependabot.com/dart-lang/site-shared/issues/161">#161</a>)</li> <li><a href="https://github.com/dart-lang/site-shared/commit/9f48c9345c4081ddf7d74f47597fe47b00f27143"><code>9f48c93</code></a> Fix dev analysis failure (<a href="https://github-redirect.dependabot.com/dart-lang/site-shared/issues/162">#162</a>)</li> <li>See full diff in <a href="https://github.com/dart-lang/site-shared/compare/cbd9b3909699a817cb945a8faeec9b0730cb4fd7...3f55d07704b43696ee36ac281a364d4f3faa19d2">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Many of these videos predate Dart 2 and all predate null safety. It would be nice to include an alternate, but better not to link to an outdated resource in the mean time.
Also adds a transition as the sentence was a bit confusing on its own. Fixes dart-lang/site-www#4363 Co-authored-by: Anthony Sansone <[email protected]>
Intro to dart:io is outdated, and the important info it contained is available on other pages (the [library tour](https://dart.dev/guides/libraries/library-tour#dartio) and [Concurrency in Dart](https://dart.dev/guides/language/concurrency)) Part of #4042
- Remove unnecessary library annotation as it is only recommended if you have annotations or doc comments - Remove import as it doesn't add to example - Switch name to Dash
Bumps [site-shared](https://github.com/dart-lang/site-shared) from `cbd9b39` to `3f55d07`. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dart-lang/site-shared/commit/3f55d07704b43696ee36ac281a364d4f3faa19d2"><code>3f55d07</code></a> Remove unused scripts after new infrastructure (<a href="https://github-redirect.dependabot.com/dart-lang/site-shared/issues/161">#161</a>)</li> <li><a href="https://github.com/dart-lang/site-shared/commit/9f48c9345c4081ddf7d74f47597fe47b00f27143"><code>9f48c93</code></a> Fix dev analysis failure (<a href="https://github-redirect.dependabot.com/dart-lang/site-shared/issues/162">#162</a>)</li> <li>See full diff in <a href="https://github.com/dart-lang/site-shared/compare/cbd9b3909699a817cb945a8faeec9b0730cb4fd7...3f55d07704b43696ee36ac281a364d4f3faa19d2">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fixes #2837 Co-authored-by: Anthony Sansone <[email protected]>
…ual section (#4366) Currently setting default values for optional named and positional parameters was separated, but it is pretty core to each topic, so this PR moves the discussion of default values to each of the parameter sections. This helps the examples make a bit more sense as they are contextualized. I've also removed the mention of migrating from `=` to `:` because it was added over 6 years ago, most code already uses `:`, the extra mention is large and potentially confusing (and don't want to duplicate it in this new layout), and in Dart 2.19 the old syntax will become a warning anyway. Also removes the mention of how list and maps can be passed. It doesn't talk about sets or other constant objects which can be passed as well and isn't super relevant to the goals of these sections. We should instead expand on our documentation of const (dart-lang/site-www#4350) elsewhere and link to that. Overall: - Moves default value discussion to named and optional positional sections instead of isolated - Better clarifies the nullable types and when they are needed, as well as how `null` is the default default value - Moves discussion of named parameters anywhere to end - Removes mention of old `=` syntax - Removes mention of how list and maps can be passed as don't want to duplicate it and it is better documented by const documentation elsewhere Fixes dart-lang/site-www#3737 Co-authored-by: Anthony Sansone <[email protected]>
Bumps ruby from `ed50d57` to `5d413e3`. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Ignores some new hints where they are not relevant due to purposely showcasing that behavior or having dead code. Also updates the diagnostic message for one updated in the dev branch.
It was our only usage of diff2html and it wasn't working anyway. It's not worth the bloat with only one (simple) usage across the site. If we need it in the future, we can always properly add support.
Update dart-sdk -> 2.18.4 Update build_runner -> 2.3.2 Update lints -> 2.0.1
[Staged page](https://dart--staging.web.app/guides/language/coming-from/js-to-dart). Original comments are in a [Google Doc](https://docs.google.com/document/d/1h7okBLXoKX2UuG7bXJSVcAQZiuV9AcRfoDKsxG5gMdg/edit#).
…#4332) While the precedence outlined by the table should only be used as a guideline, users are instead finding third-party sources when googling which do not highlight potential issues and are not able to identify/search that this table still approximates the behavior even if they navigate to the language tour. This PR makes the table more searchable and identifiable as outlining the approximate precedence, while also clarifying the warning which was a bit confusing, focusing on that it can just be used as a "helpful guide". Beyond that, this adds the associativity labels present on the language spec's "helpful guide". Fixes #4287 **Staged:** https://dart-dev--pr4332-feature-document-ass-ys8cfbyn.web.app/guides/language/language-tour#operators Co-authored-by: Anthony Sansone <[email protected]>
AlexV525
reviewed
Nov 28, 2022
Co-authored-by: Alex Li <[email protected]>
Co-authored-by: Alex Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123
希望这个 sync 可以让 CI 通过。