[sync] 2022/11/28

.github/workflows/codeql-analysis.yml

@@ -33,7 +33,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@18fe527fa8b29f134bb91f32f1a5dc5abb15ed7f
+        uses: github/codeql-action/init@678fc3afe258fb2e0cdc165ccf77b85719de7b3c
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -44,7 +44,7 @@ jobs:
       # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
       - name: Autobuild
-        uses: github/codeql-action/autobuild@18fe527fa8b29f134bb91f32f1a5dc5abb15ed7f
+        uses: github/codeql-action/autobuild@678fc3afe258fb2e0cdc165ccf77b85719de7b3c
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 https://git.io/JvXDl
@@ -58,4 +58,4 @@ jobs:
       #   make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@18fe527fa8b29f134bb91f32f1a5dc5abb15ed7f
+        uses: github/codeql-action/analyze@678fc3afe258fb2e0cdc165ccf77b85719de7b3c

.github/workflows/scorecards-analysis.yml

@@ -49,6 +49,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@18fe527fa8b29f134bb91f32f1a5dc5abb15ed7f
+        uses: github/codeql-action/upload-sarif@678fc3afe258fb2e0cdc165ccf77b85719de7b3c
         with:
           sarif_file: results.sarif

Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:3-slim-bullseye@sha256:ed50d5719f8ecd0bae4d26bc91672f130463d7be05b67433ab595af39da1a95d as base
+FROM ruby:3-slim-bullseye@sha256:5d413e301f37cbe63a54dadded2f347496165c1de0dbe342d1f0f0d47e25b2be as base
 
 ENV DEBIAN_FRONTEND=noninteractive
 ENV TZ=US/Pacific

examples/analysis/analyzer-results-dev.txt

@@ -1,7 +1,7 @@
 Analyzing analysis...
 
   error - lib/strict_modes.dart:15:7 - The argument type 'dynamic' can't be assigned to the parameter type 'List<String>'. - argument_type_not_assignable
-   info - lib/lint.dart:9:19 - Avoid empty statements. - empty_statements
+   info - lib/lint.dart:9:19 - Unnecessary empty statement. Try removing the empty statement or restructuring the code. - empty_statements
    info - lib/lint.dart:17:7 - Close instances of `dart.core.Sink`. - close_sinks
    info - lib/strict_modes.dart:22:17 - The type argument(s) of 'Map' can't be inferred. Use explicit type argument(s) for 'Map'. - inference_failure_on_collection_literal
    info - lib/strict_modes.dart:33:3 - The generic type 'List<dynamic>' should have explicit type arguments but doesn't. Use explicit type arguments for 'List<dynamic>'. - strict_raw_type

examples/misc/lib/effective_dart/usage_bad.dart

@@ -6,6 +6,7 @@
 // ignore_for_file: avoid_function_literals_in_foreach_calls, prefer_function_declarations_over_variables
 // ignore_for_file: prefer_adjacent_string_concatenation, prefer_is_not_empty, prefer_interpolation_to_compose_strings
 // ignore_for_file: unnecessary_this, always_declare_return_types, no_leading_underscores_for_local_identifiers
+// ignore_for_file: deprecated_colon_for_default_value
 import 'dart:async';
 import 'dart:io';
 import 'dart:math';

examples/misc/lib/effective_dart/usage_good.dart

@@ -1,7 +1,7 @@
 // ignore_for_file: type_annotate_public_apis, unused_element, unused_local_variable
 // ignore_for_file: prefer_function_declarations_over_variables, strict_raw_type,
 // ignore_for_file: prefer_initializing_formals, prefer_typing_uninitialized_variables
-// ignore_for_file: use_super_parameters
+// ignore_for_file: use_super_parameters, dead_code
 import 'dart:async';
 import 'dart:io';
 import 'dart:math';

examples/misc/lib/language_tour/functions.dart

@@ -55,21 +55,6 @@ void miscDeclAnalyzedButNotTested() {
     // #enddocregion named-parameter-default-values
   }
 
-  {
-    // #docregion list-map-default-function-param
-    void doStuff(
-        {List<int> list = const [1, 2, 3],
-        Map<String, String> gifts = const {
-          'first': 'paper',
-          'second': 'cotton',
-          'third': 'leather'
-        }}) {
-      print('list:  $list');
-      print('gifts: $gifts');
-    }
-    // #enddocregion list-map-default-function-param
-  }
-
   {
     // #docregion function-as-param
     void printElement(int element) {
@@ -95,3 +80,9 @@ class Scrollbar extends Widget {
   const Scrollbar({super.key, required Widget child});
   // #enddocregion required-named-parameters
 }
+
+class ScrollbarTwo extends Widget {
+  // #docregion required-named-parameters-nullable
+  const ScrollbarTwo({super.key, required Widget? child});
+  // #enddocregion required-named-parameters-nullable
+}

examples/misc/lib/language_tour/metadata/misc.dart

@@ -1,6 +1,8 @@
 import 'todo.dart';
 
-@Todo('seth', 'make this do something')
+// #docregion
+@Todo('Dash', 'Implement this function')
 void doSomething() {
-  print('do something');
+  print('Do something');
 }
+// #enddocregion

examples/misc/lib/language_tour/metadata/todo.dart

@@ -1,5 +1,3 @@
-library todo;
-
 class Todo {
   final String who;
   final String what;

examples/misc/test/library_tour/io_test.dart

@@ -58,7 +58,7 @@ void main() {
     }
 
     // #enddocregion try-catch
-    expect(main, prints(startsWith('FileSystemException')));
+    expect(main, prints(contains('Cannot open file')));
   });
 
   test('read-from-stream', () {

firebase.json

@@ -55,6 +55,7 @@
       { "source": "/articles/language/optional-types", "destination": "/faq#types", "type": 301 },
       { "source": "/articles/libraries", "destination": "/articles", "type": 301 },
       { "source": "/articles/libraries/converters-and-codecs", "destination": "/articles/archive/converters-and-codecs", "type": 301 },
+      { "source": "/articles/libraries/dart-io", "destination": "/guides/libraries/library-tour#dartio", "type": 301 },
       { "source": "/articles/libraries/zones", "destination": "/articles/archive/zones", "type": 301 },
       { "source": "/articles/m*{,/**}", "destination": "/articles", "type": 301 },
       { "source": "/articles/m1-language-changes{,/**}", "destination": "/guides/language/spec", "type": 301 },
@@ -138,6 +139,7 @@
 
       { "source": "/go/analysis-server-protocol", "destination": "https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/doc/api.html", "type": 301 },
       { "source": "/go/cloud", "destination": "/server/google-cloud?utm_source=go-link&utm_medium=referral&utm_campaign=go-cloud", "type": 301 },
+      { "source": "/go/content-hashes", "destination": "https://github.com/dart-lang/site-www/issues/4361", "type": 301 },
       { "source": "/go/core-lints", "destination": "https://github.com/dart-lang/lints", "type": 301 },
       { "source": "/go/dart-fix", "destination": "/tools/dart-fix", "type": 301 },
       { "source": "/go/dartdoc-options-file", "destination": "https://github.com/dart-lang/dartdoc#dartdoc_optionsyaml", "type": 301 },

pubspec.yaml

@@ -3,13 +3,13 @@ name: site_www
 homepage: https://dart.dev
 
 environment:
-  sdk: '>=2.18.1 <3.0.0'
+  sdk: '>=2.18.4 <3.0.0'
 
 dev_dependencies:
-  build_runner: ^2.1.0
+  build_runner: ^2.3.2
   code_excerpt_updater:
     path: site-shared/packages/code_excerpt_updater
   code_excerpter:
     path: site-shared/packages/code_excerpter
   linkcheck: ^2.0.19
-  lints: ^2.0.0
+  lints: ^2.0.1