Night mode on CheeseDetailsActivity #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-caryl
force-pushed
the
night_mode_details
branch
from
22269b3 to
6bf9617
Compare
|
Updated, removed casts no longer required with support lib v26. |
nachtien
suggested changes
Dec 28, 2017
| private void setNightMode(@AppCompatDelegate.NightMode int nightMode) { | ||
| AppCompatDelegate.setDefaultNightMode(nightMode); | ||
|
|
||
| activity.recreate(); |
There was a problem hiding this comment.
What about the grandparent activity (parent of the parent)? It might not be destroyed, causing the new mode not to be set. @chrisbanes, this is an issue we ran into, and I assume this is why it wasn't implemented here because it's a bit of a hack job.
We used startActivityForResult in our implementation, and then set the result code based on if the theme was changed or not, and depending on what code was returned, we recreate the activity. Activities before the parent wouldn't be updated unless Android destroys them and they are restarted. Anyone know of the best way around this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisbanes on the
CheeseDetailsActivitythere's the 'Night mode' menu, but it doesn't show the correctly checked mode, and selecting the items does nothing. I've extracted the code to handle the checking and selecting into a helper class — seemed neater than putting it in a common base class.I bumped the gradle/support lib versions at the same time, good to keep up-to-date.