-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Night mode on CheeseDetailsActivity #36
Open
jonathan-caryl
wants to merge
2
commits into
chrisbanes:master
Choose a base branch
from
jonathan-caryl:night_mode_details
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−67
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
app/src/main/java/com/support/android/designlibdemo/NightModeUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| package com.support.android.designlibdemo; | ||
|
|
||
| import android.app.Activity; | ||
| import android.support.annotation.NonNull; | ||
| import android.support.v7.app.AppCompatDelegate; | ||
| import android.view.Menu; | ||
| import android.view.MenuItem; | ||
|
|
||
| class NightModeUtils { | ||
| private Activity activity; | ||
|
|
||
| private NightModeUtils(@NonNull Activity activity) { | ||
| this.activity = activity; | ||
| } | ||
|
|
||
| static NightModeUtils from(@NonNull Activity activity) { | ||
| return new NightModeUtils(activity); | ||
| } | ||
|
|
||
| boolean checkNightMode(@NonNull Menu menu) { | ||
| switch (AppCompatDelegate.getDefaultNightMode()) { | ||
| case AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM: | ||
| menu.findItem(R.id.menu_night_mode_system).setChecked(true); | ||
| break; | ||
| case AppCompatDelegate.MODE_NIGHT_AUTO: | ||
| menu.findItem(R.id.menu_night_mode_auto).setChecked(true); | ||
| break; | ||
| case AppCompatDelegate.MODE_NIGHT_YES: | ||
| menu.findItem(R.id.menu_night_mode_night).setChecked(true); | ||
| break; | ||
| case AppCompatDelegate.MODE_NIGHT_NO: | ||
| menu.findItem(R.id.menu_night_mode_day).setChecked(true); | ||
| break; | ||
| default: | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| boolean onNightModeItemSelected(@NonNull MenuItem item) { | ||
| switch (item.getItemId()) { | ||
| case R.id.menu_night_mode_system: | ||
| setNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM); | ||
| break; | ||
| case R.id.menu_night_mode_day: | ||
| setNightMode(AppCompatDelegate.MODE_NIGHT_NO); | ||
| break; | ||
| case R.id.menu_night_mode_night: | ||
| setNightMode(AppCompatDelegate.MODE_NIGHT_YES); | ||
| break; | ||
| case R.id.menu_night_mode_auto: | ||
| setNightMode(AppCompatDelegate.MODE_NIGHT_AUTO); | ||
| break; | ||
| default: | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| private void setNightMode(@AppCompatDelegate.NightMode int nightMode) { | ||
| AppCompatDelegate.setDefaultNightMode(nightMode); | ||
|
|
||
| activity.recreate(); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #Fri Jun 09 10:31:39 BST 2017 | ||
| #Sat Sep 16 08:45:03 BST 2017 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-milestone-1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the grandparent activity (parent of the parent)? It might not be destroyed, causing the new mode not to be set. @chrisbanes, this is an issue we ran into, and I assume this is why it wasn't implemented here because it's a bit of a hack job.
We used startActivityForResult in our implementation, and then set the result code based on if the theme was changed or not, and depending on what code was returned, we recreate the activity. Activities before the parent wouldn't be updated unless Android destroys them and they are restarted. Anyone know of the best way around this?