Readme: Improve instructions #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the instructions for building pwru by listing additional tools that are required to build it. Besides that it adds a step for building the libpcap. Signed-off-by: darox <[email protected]>
brb
reviewed
Oct 17, 2023
README.md
Outdated
|
|
||
| ### Building | ||
|
|
||
|
|
||
| Build libpcap before building pwru: |
There was a problem hiding this comment.
I think this is not needed, as the dependency https://github.com/cilium/pwru/blob/main/Makefile#L17 should trigger the libpcap build process.
darox
force-pushed
the
extend-build-dependencies
branch
from
55072f9 to
9ee9d58
Compare
darox
force-pushed
the
extend-build-dependencies
branch
from
9ee9d58 to
af9b7fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the instructions for building pwru by listing additional tools that are required to build it. Besides that it adds a step for building the libpcap.