Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Improve instructions #267

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Readme: Improve instructions #267

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a9426
Readme: Improve instructions
darox Oct 16, 2023
af9b7fb
remove instruction to build libpcap
darox Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,21 @@ See [docs/vagrant.md](docs/vagrant.md)

* Go >= 1.16
* LLVM/clang >= 1.12
* Bison
* Lex/Flex >= 2.5.31

### Building


Build libpcap before building pwru:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed, as the dependency https://github.com/cilium/pwru/blob/main/Makefile#L17 should trigger the libpcap build process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.

```
make libpcap/libpcap.a
```
make

Now you can build pwru:
```
make
``````

Alternatively, you can build in the Docker container:

Expand Down